-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ES3ink board #331
Add ES3ink board #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the PR template description and make following changes
- UF2_BOARD_ID is not correct
- remove adafruit favicon
- provide link to vid/pid
- fix for UF2_BOARD_ID - removed favicon
I added link for VID/PID to PR comment and fixed issues which you mentioned. Thanks |
your PID PR is still opened, have you allocated with the PID yet ? |
Sorry, I do not now what you mean by that. Could you rephrase your question? Thanks |
sorry, I mean did your request for the PID is accepted yet ? |
No, I'm waiting for somebody to make a review, but I do not expect to be declined. I understand if you want wait until will be accepted. |
PID approval is mandatory, I will mark this PR as draft for now. Please mark it as ready when you have PID allocated. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good, thank you
Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Link
UF2_BOARD_ID
in your board.h follow correct format from uf2 specsDescription of Change
Add ES3ink board