Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite translated URL's #59

Open
adamchainz opened this issue Sep 18, 2021 · 1 comment
Open

Rewrite translated URL's #59

adamchainz opened this issue Sep 18, 2021 · 1 comment

Comments

@adamchainz
Copy link
Owner

adamchainz commented Sep 18, 2021

It's theoretically possible to rewrite old url() calls using translation to the new path format, e.g.

-from django.conf.urls import url
+from django.urls import re_path
 from django.utils.translation import gettext_lazy as _

-url(_(r'^about/$'), views.about)
+path(_(r'about/'), views.about)

State.from_imports would need extending to track aliases as it currently ignores them.

@adamchainz
Copy link
Owner Author

Or we could just track the import independently in the fixer module, like in the recent admin fixers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant