Changed adlast2.Module::Decl from Map to Vec, WIP for tsgen #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbod7
approved these changes
Mar 17, 2023
rust/compiler/Cargo.lock
Outdated
There was a problem hiding this comment.
If there's now a top level Cargo.lock files that captures all deps, shouldn't this go?
Cargo.lock
Outdated
There was a problem hiding this comment.
This is against my taste. My intention with the repo was that language specific stuff goes in language specific directories. Otherwise we'll end up with all config file for all sorts of languages up here.
But let's go with this for now if it improves your dev experience.
rust/compiler/src/cli/tsgen.rs
Outdated
| } | ||
| } | ||
| for mn in &opts.modules { | ||
| // TODO why is the resolver by the filename not the module name |
There was a problem hiding this comment.
I don't understand this comment/question.
millergarym
added a commit
to millergarym/adl
that referenced
this pull request
May 2, 2023
commit b00e8ba Author: Gary Miller <[email protected]> Date: Tue May 2 14:15:11 2023 +1000 change release name commit 392d95e Author: Gary Miller <[email protected]> Date: Tue May 2 14:06:59 2023 +1000 reverting to a version step commit 1cc6b00 Author: Gary Miller <[email protected]> Date: Tue May 2 13:46:37 2023 +1000 looks like actions/download-artifact@v3 might be case sensative commit 8d70fe4 Author: Gary Miller <[email protected]> Date: Tue May 2 13:30:23 2023 +1000 fix rust-release.yaml commit dd18a2a Author: Gary Miller <[email protected]> Date: Tue May 2 13:25:06 2023 +1000 change actions/[email protected] and actions/[email protected] to softprops/action-gh-release@v1 commit 56695d0 Author: Gary Miller <[email protected]> Date: Tue May 2 12:33:06 2023 +1000 rust release - cache, checkout@v3, rust tooling provided commit ec8128c Author: Gary Miller <[email protected]> Date: Tue May 2 12:03:11 2023 +1000 asset_content_type: application/octet-stream commit 71c1140 Author: Gary Miller <[email protected]> Date: Tue May 2 11:34:34 2023 +1000 trim 24 chars from GITHUB_REF commit a651565 Author: Gary Miller <[email protected]> Date: Tue May 2 10:56:09 2023 +1000 commit on gm master commit ad56334 Author: Gary Miller <[email protected]> Date: Tue May 2 10:46:07 2023 +1000 rust-release.yaml commit fe6a159 Author: Gary Miller <[email protected]> Date: Tue May 2 09:36:20 2023 +1000 error on unknown fields for AdlWorkspace0 commit 976e9c3 Author: Gary Miller <[email protected]> Date: Mon May 1 19:51:33 2023 +1000 create tsconfig based on config - named_options commit 3a5ed05 Author: Gary Miller <[email protected]> Date: Mon May 1 17:13:01 2023 +1000 packagable - don't gen index.ts or write runtime's not .ts files commit 52dfa52 Author: Gary Miller <[email protected]> Date: Mon May 1 15:47:41 2023 +1000 added args for log init commit d4df193 Author: Gary Miller <[email protected]> Date: Mon May 1 11:14:48 2023 +1000 separate local and dep in resolver.ts commit bc5c6ab Author: Gary Miller <[email protected]> Date: Thu Apr 27 19:43:42 2023 +1000 unioned dir and embedded commit a09b0ca Author: Gary Miller <[email protected]> Date: Wed Apr 26 20:52:28 2023 +1000 a work version commit 9c5a401 Author: Gary Miller <[email protected]> Date: Wed Apr 26 16:57:30 2023 +1000 wip: getting typescript/workspace to work - manual edits commit 2a09c7e Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:22:22 2023 +1000 step: pnpm add -D typescript @types/node following https://brockherion.dev/blog/posts/setting-up-a-monorepo-with-pnpm-and-typescript/ commit 05f3da5 Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:21:28 2023 +1000 added gitinore at typescript/workspace commit dda2c7f Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:20:09 2023 +1000 step: pnpm init commit b50c741 Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:14:26 2023 +1000 moved typescript/tests to typescript/tests/cli commit 2e2b00f Author: Gary Miller <[email protected]> Date: Mon Apr 24 23:39:51 2023 +1000 wip gen index.ts(s) commit 72067b0 Author: Gary Miller <[email protected]> Date: Mon Apr 24 11:04:05 2023 +1000 using rust_embed for ts runtime commit 9007c6f Author: Gary Miller <[email protected]> Date: Fri Apr 21 16:27:51 2023 +1000 work workspace gens commit 6cc7069 Author: Gary Miller <[email protected]> Date: Fri Apr 21 10:39:16 2023 +1000 moved annontation injection out a bit commit 020682d Author: Gary Miller <[email protected]> Date: Fri Apr 21 10:37:59 2023 +1000 modified tests needing sys.annotations, fix tsgen to check for type params withs params commit ac20a81 Author: Gary Miller <[email protected]> Date: Fri Apr 21 09:29:03 2023 +1000 move embedded_sys_loader details into packaging.adl commit c8c980e Author: Gary Miller <[email protected]> Date: Thu Apr 20 20:22:30 2023 +1000 check len type params commit cd27893 Author: Gary Miller <[email protected]> Date: Wed Apr 19 22:12:35 2023 +1000 creating package.json files commit 9743a45 Author: Gary Miller <[email protected]> Date: Wed Apr 19 17:59:59 2023 +1000 wip generating package.json(s) commit 8aa3ac5 Author: Gary Miller <[email protected]> Date: Wed Apr 19 16:04:08 2023 +1000 generating ts in folders for each adl package commit a00210b Author: Gary Miller <[email protected]> Date: Wed Apr 19 13:12:42 2023 +1000 wip commit c9545fe Author: Gary Miller <[email protected]> Date: Wed Apr 19 00:44:44 2023 +1000 injecting npm_pkg_name as annotation commit ecd01be Author: Gary Miller <[email protected]> Date: Tue Apr 18 22:56:51 2023 +1000 changed tsgen to take TypescriptGenOptions instead of TsOpts commit 0363541 Author: Gary Miller <[email protected]> Date: Tue Apr 18 21:11:06 2023 +1000 simple npm packge import commit 54d3d06 Author: Gary Miller <[email protected]> Date: Tue Apr 18 17:07:45 2023 +1000 wip : picked from -named attempt commit f4465af Author: Gary Miller <[email protected]> Date: Mon Apr 17 14:20:50 2023 +1000 fix circular ref testing commit 5c940b7 Author: Gary Miller <[email protected]> Date: Mon Apr 17 13:11:45 2023 +1000 1st working version of a workspace commit 7736092 Author: Gary Miller <[email protected]> Date: Mon Apr 17 12:07:51 2023 +1000 wip gen workspace commit db5f48a Author: Gary Miller <[email protected]> Date: Fri Apr 14 17:08:56 2023 +1000 wip on work & pkg commit 512ec6b Author: Gary Miller <[email protected]> Date: Fri Apr 14 15:02:01 2023 +1000 wip commit 9285ba4 Author: Gary Miller <[email protected]> Date: Fri Apr 14 14:44:42 2023 +1000 wip: define workspace and packaging defs commit 8658ee9 Author: Gary Miller <[email protected]> Date: Tue Apr 4 18:48:29 2023 +1000 embedded adl stdlib commit 6d44cc5 Author: Gary Miller <[email protected]> Date: Tue Apr 4 17:02:09 2023 +1000 capitalise type names commit e46f7e1 Author: Gary Miller <[email protected]> Date: Tue Apr 4 15:41:08 2023 +1000 fix rel_import commit a9d4fc7 Author: Gary Miller <[email protected]> Date: Tue Apr 4 14:39:09 2023 +1000 working for protoapp commit 2474bb4 Author: Gary Miller <[email protected]> Date: Tue Apr 4 12:31:18 2023 +1000 gen TypeToken literal, changed cli args to match adlc commit 7d5b1e2 Author: Gary Miller <[email protected]> Date: Tue Apr 4 10:41:21 2023 +1000 gen doc comments more consistent with adlc commit 6d02bba Author: Gary Miller <[email protected]> Date: Mon Apr 3 21:25:36 2023 +1000 added optional output dir to table table data commit 059ddab Author: Gary Miller <[email protected]> Date: Mon Apr 3 21:01:58 2023 +1000 generating resolver commit 7d68841 Author: Gary Miller <[email protected]> Date: Mon Apr 3 17:07:46 2023 +1000 modify and copy ts runtime commit bf27d87 Author: Gary Miller <[email protected]> Date: Mon Apr 3 13:57:49 2023 +1000 wip: generating TS for all tests commit 55102d4 Author: Gary Miller <[email protected]> Date: Tue Mar 28 22:02:30 2023 +1100 test module names match filename, added test meta data 'testing_table.json' commit 4a679b3 Author: Gary Miller <[email protected]> Date: Tue Mar 28 21:28:41 2023 +1100 assert_module_file_err commit f7717b9 Author: Gary Miller <[email protected]> Date: Tue Mar 28 21:21:50 2023 +1100 modified rust tests to match git mv commit 5412bd4 Author: Gary Miller <[email protected]> Date: Tue Mar 28 20:41:33 2023 +1100 moved and renamed adl test files commit ea6d9bb Author: Tim Docker <[email protected]> Date: Fri Mar 24 08:31:47 2023 +1100 fix multiline doc string handling commit 95d6711 Author: Tim Docker <[email protected]> Date: Fri Mar 24 08:04:58 2023 +1100 more codegen commit 0e56f2a Author: Gary Miller <[email protected]> Date: Thu Mar 23 21:22:03 2023 +1100 tsgen localnames, primitives and type_params for union and struct underscore before unused type params fix: compiler warnings commit d3fee87 Author: Tim Docker <[email protected]> Date: Thu Mar 23 10:03:36 2023 +1100 more codegen commit 82eb63f Author: Tim Docker <[email protected]> Date: Wed Mar 22 09:26:08 2023 +1100 starting to flesh out rust codegen commit 1b59a31 Author: Tim Docker <[email protected]> Date: Tue Mar 21 22:38:42 2023 +1100 added expected rust output for test 2 commit ef2fc45 Author: Tim Docker <[email protected]> Date: Tue Mar 21 22:31:32 2023 +1100 fix resolver so that O(n) lookups now use hashing commit 9ad88b1 Merge: 4b06e95 378f21d Author: Tim Docker <[email protected]> Date: Fri Mar 17 17:15:26 2023 +1100 Merge branch 'master' into rust-tooling commit 4b06e95 Author: Gary Miller <[email protected]> Date: Fri Mar 17 13:11:33 2023 +1100 adding tim's comment on adl-lang#184 commit 2c40435 Author: Gary Miller <[email protected]> Date: Thu Mar 16 19:07:55 2023 +1100 Start of tsgen tooling commit e752e7d Author: Tim Docker <[email protected]> Date: Wed Mar 15 21:49:23 2023 +1100 fix refs to relocated adl test files commit 6064473 Author: Tim Docker <[email protected]> Date: Sun Feb 12 20:44:10 2023 +1100 generate structured rust module tree commit 476e831 Author: Tim Docker <[email protected]> Date: Sat Feb 11 22:04:18 2023 +1100 switch to using clap derive for command line parsing commit 4e4ea7c Author: Tim Docker <[email protected]> Date: Sat Feb 11 04:35:14 2023 +1100 make test adl files into top level dir, and make names consistent with module names commit 2d3f3aa Author: Tim Docker <[email protected]> Date: Sat Feb 11 04:26:54 2023 +1100 wip: rust generation commit a4328c6 Author: Gary Miller <[email protected]> Date: Tue Mar 14 18:18:08 2023 +1100 fix: 'cargo test' working commit 4efbedc Author: Tim Docker <[email protected]> Date: Fri Dec 9 14:33:20 2022 +1300 remove spans from the ast until we work out how to reconcile them with abstract loading commit a703089 Author: Tim Docker <[email protected]> Date: Fri Dec 9 08:30:16 2022 +1300 simplified error handling in resolver commit dcc79e1 Author: Tim Docker <[email protected]> Date: Fri Dec 9 08:14:47 2022 +1300 use env_logger framework commit 806f5c7 Author: Tim Docker <[email protected]> Date: Fri Dec 9 08:11:20 2022 +1300 added duplicate checks commit cdac963 Author: Tim Docker <[email protected]> Date: Thu Dec 8 22:51:01 2022 +1300 added a doc describing ADL processing steps commit 8c0a940 Author: Tim Docker <[email protected]> Date: Thu Dec 8 16:49:59 2022 +1300 include local references in emitted ast commit 8135a06 Author: Tim Docker <[email protected]> Date: Thu Dec 8 13:36:29 2022 +1300 Added an ast cli command commit c8be33c Author: Tim Docker <[email protected]> Date: Thu Dec 8 12:21:59 2022 +1300 fleshing out the resolver commit e43f444 Author: Tim Docker <[email protected]> Date: Wed Dec 7 21:43:50 2022 +1300 improved parser error messages commit 0805b16 Author: Tim Docker <[email protected]> Date: Wed Dec 7 16:08:53 2022 +1300 fleshing out verification command commit a360977 Author: Tim Docker <[email protected]> Date: Wed Dec 7 13:55:39 2022 +1300 boilerplate for a cli commit 653f15f Author: Tim Docker <[email protected]> Date: Fri Aug 19 12:35:30 2022 +1000 wip: loader commit 2ef114e Author: Tim Docker <[email protected]> Date: Thu Aug 18 17:19:27 2022 +1000 wip: resolver commit 73a45b4 Author: Tim Docker <[email protected]> Date: Tue Aug 16 09:55:03 2022 +1000 tests for apply_explicit_annotations commit 156f0c0 Author: Tim Docker <[email protected]> Date: Mon Aug 15 21:58:15 2022 +1000 implemented apply_explicit_annotations commit 1d4c6a6 Author: Tim Docker <[email protected]> Date: Mon Aug 15 20:23:14 2022 +1000 fix up warnings commit e29d2e0 Author: Tim Docker <[email protected]> Date: Mon Aug 15 20:19:39 2022 +1000 fix parsing of docstrings and annotations commit 9acb077 Author: Tim Docker <[email protected]> Date: Mon Aug 15 15:51:18 2022 +1000 parse (defunct?) decl version numbers if present commit aa5720c Author: Tim Docker <[email protected]> Date: Sun May 8 18:59:50 2022 +1000 located parsing commit 40e6c99 Author: Tim Docker <[email protected]> Date: Thu Apr 28 22:12:53 2022 +1000 Factor scratch build script commit 05b12ae Author: Tim Docker <[email protected]> Date: Wed Apr 27 11:34:04 2022 +1000 Split parser modules into separate files commit bddb2eb Author: Tim Docker <[email protected]> Date: Wed Apr 27 11:27:53 2022 +1000 Added field level annotations commit 010ed7d Author: Tim Docker <[email protected]> Date: Wed Apr 27 10:56:16 2022 +1000 Added imports to parser commit ee21025 Author: Tim Docker <[email protected]> Date: Tue Apr 26 19:02:38 2022 +1000 Added parsing of explicit annotations commit 0c2fe8e Author: Tim Docker <[email protected]> Date: Tue Apr 26 09:25:24 2022 +1000 Simplify with imports commit d2f60b1 Author: Tim Docker <[email protected]> Date: Thu Apr 21 17:27:57 2022 +1000 Annotations and docstrings commit 74203ec Author: Tim Docker <[email protected]> Date: Thu Apr 21 10:34:48 2022 +1000 Improve json string processing commit c8db1e9 Author: Tim Docker <[email protected]> Date: Thu Apr 21 08:28:23 2022 +1000 json parsing commit 9f5511f Author: Tim Docker <[email protected]> Date: Thu Apr 14 14:33:47 2022 +1000 parser fixes commit 92233db Author: Tim Docker <[email protected]> Date: Wed Apr 6 14:09:23 2022 +1000 WIP: rust parser commit b212413 Author: Tim Docker <[email protected]> Date: Sun Apr 3 15:04:22 2022 +1000 WIP: rust parser commit 6acb467 Author: Tim Docker <[email protected]> Date: Sun Apr 3 15:04:02 2022 +1000 WIP: rust parser commit 3b23dd8 Author: Tim Docker <[email protected]> Date: Sun Apr 3 14:05:03 2022 +1000 WIP: rust parser commit df8c786 Author: Tim Docker <[email protected]> Date: Sun Apr 3 10:06:49 2022 +1000 Starter project for rust tooling commit 1d818b0 Author: Tim Docker <[email protected]> Date: Sun Apr 3 15:03:31 2022 +1000 Add Debug to derived traits in rust code commit eed543b Author: Tim Docker <[email protected]> Date: Sun Apr 3 10:03:49 2022 +1000 Adding missing mapentry to published rust runtime
millergarym
added a commit
to millergarym/adl
that referenced
this pull request
May 2, 2023
commit b00e8ba Author: Gary Miller <[email protected]> Date: Tue May 2 14:15:11 2023 +1000 change release name commit 392d95e Author: Gary Miller <[email protected]> Date: Tue May 2 14:06:59 2023 +1000 reverting to a version step commit 1cc6b00 Author: Gary Miller <[email protected]> Date: Tue May 2 13:46:37 2023 +1000 looks like actions/download-artifact@v3 might be case sensative commit 8d70fe4 Author: Gary Miller <[email protected]> Date: Tue May 2 13:30:23 2023 +1000 fix rust-release.yaml commit dd18a2a Author: Gary Miller <[email protected]> Date: Tue May 2 13:25:06 2023 +1000 change actions/[email protected] and actions/[email protected] to softprops/action-gh-release@v1 commit 56695d0 Author: Gary Miller <[email protected]> Date: Tue May 2 12:33:06 2023 +1000 rust release - cache, checkout@v3, rust tooling provided commit ec8128c Author: Gary Miller <[email protected]> Date: Tue May 2 12:03:11 2023 +1000 asset_content_type: application/octet-stream commit 71c1140 Author: Gary Miller <[email protected]> Date: Tue May 2 11:34:34 2023 +1000 trim 24 chars from GITHUB_REF commit a651565 Author: Gary Miller <[email protected]> Date: Tue May 2 10:56:09 2023 +1000 commit on gm master commit ad56334 Author: Gary Miller <[email protected]> Date: Tue May 2 10:46:07 2023 +1000 rust-release.yaml commit fe6a159 Author: Gary Miller <[email protected]> Date: Tue May 2 09:36:20 2023 +1000 error on unknown fields for AdlWorkspace0 commit 976e9c3 Author: Gary Miller <[email protected]> Date: Mon May 1 19:51:33 2023 +1000 create tsconfig based on config - named_options commit 3a5ed05 Author: Gary Miller <[email protected]> Date: Mon May 1 17:13:01 2023 +1000 packagable - don't gen index.ts or write runtime's not .ts files commit 52dfa52 Author: Gary Miller <[email protected]> Date: Mon May 1 15:47:41 2023 +1000 added args for log init commit d4df193 Author: Gary Miller <[email protected]> Date: Mon May 1 11:14:48 2023 +1000 separate local and dep in resolver.ts commit bc5c6ab Author: Gary Miller <[email protected]> Date: Thu Apr 27 19:43:42 2023 +1000 unioned dir and embedded commit a09b0ca Author: Gary Miller <[email protected]> Date: Wed Apr 26 20:52:28 2023 +1000 a work version commit 9c5a401 Author: Gary Miller <[email protected]> Date: Wed Apr 26 16:57:30 2023 +1000 wip: getting typescript/workspace to work - manual edits commit 2a09c7e Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:22:22 2023 +1000 step: pnpm add -D typescript @types/node following https://brockherion.dev/blog/posts/setting-up-a-monorepo-with-pnpm-and-typescript/ commit 05f3da5 Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:21:28 2023 +1000 added gitinore at typescript/workspace commit dda2c7f Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:20:09 2023 +1000 step: pnpm init commit b50c741 Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:14:26 2023 +1000 moved typescript/tests to typescript/tests/cli commit 2e2b00f Author: Gary Miller <[email protected]> Date: Mon Apr 24 23:39:51 2023 +1000 wip gen index.ts(s) commit 72067b0 Author: Gary Miller <[email protected]> Date: Mon Apr 24 11:04:05 2023 +1000 using rust_embed for ts runtime commit 9007c6f Author: Gary Miller <[email protected]> Date: Fri Apr 21 16:27:51 2023 +1000 work workspace gens commit 6cc7069 Author: Gary Miller <[email protected]> Date: Fri Apr 21 10:39:16 2023 +1000 moved annontation injection out a bit commit 020682d Author: Gary Miller <[email protected]> Date: Fri Apr 21 10:37:59 2023 +1000 modified tests needing sys.annotations, fix tsgen to check for type params withs params commit ac20a81 Author: Gary Miller <[email protected]> Date: Fri Apr 21 09:29:03 2023 +1000 move embedded_sys_loader details into packaging.adl commit c8c980e Author: Gary Miller <[email protected]> Date: Thu Apr 20 20:22:30 2023 +1000 check len type params commit cd27893 Author: Gary Miller <[email protected]> Date: Wed Apr 19 22:12:35 2023 +1000 creating package.json files commit 9743a45 Author: Gary Miller <[email protected]> Date: Wed Apr 19 17:59:59 2023 +1000 wip generating package.json(s) commit 8aa3ac5 Author: Gary Miller <[email protected]> Date: Wed Apr 19 16:04:08 2023 +1000 generating ts in folders for each adl package commit a00210b Author: Gary Miller <[email protected]> Date: Wed Apr 19 13:12:42 2023 +1000 wip commit c9545fe Author: Gary Miller <[email protected]> Date: Wed Apr 19 00:44:44 2023 +1000 injecting npm_pkg_name as annotation commit ecd01be Author: Gary Miller <[email protected]> Date: Tue Apr 18 22:56:51 2023 +1000 changed tsgen to take TypescriptGenOptions instead of TsOpts commit 0363541 Author: Gary Miller <[email protected]> Date: Tue Apr 18 21:11:06 2023 +1000 simple npm packge import commit 54d3d06 Author: Gary Miller <[email protected]> Date: Tue Apr 18 17:07:45 2023 +1000 wip : picked from -named attempt commit f4465af Author: Gary Miller <[email protected]> Date: Mon Apr 17 14:20:50 2023 +1000 fix circular ref testing commit 5c940b7 Author: Gary Miller <[email protected]> Date: Mon Apr 17 13:11:45 2023 +1000 1st working version of a workspace commit 7736092 Author: Gary Miller <[email protected]> Date: Mon Apr 17 12:07:51 2023 +1000 wip gen workspace commit db5f48a Author: Gary Miller <[email protected]> Date: Fri Apr 14 17:08:56 2023 +1000 wip on work & pkg commit 512ec6b Author: Gary Miller <[email protected]> Date: Fri Apr 14 15:02:01 2023 +1000 wip commit 9285ba4 Author: Gary Miller <[email protected]> Date: Fri Apr 14 14:44:42 2023 +1000 wip: define workspace and packaging defs commit 8658ee9 Author: Gary Miller <[email protected]> Date: Tue Apr 4 18:48:29 2023 +1000 embedded adl stdlib commit 6d44cc5 Author: Gary Miller <[email protected]> Date: Tue Apr 4 17:02:09 2023 +1000 capitalise type names commit e46f7e1 Author: Gary Miller <[email protected]> Date: Tue Apr 4 15:41:08 2023 +1000 fix rel_import commit a9d4fc7 Author: Gary Miller <[email protected]> Date: Tue Apr 4 14:39:09 2023 +1000 working for protoapp commit 2474bb4 Author: Gary Miller <[email protected]> Date: Tue Apr 4 12:31:18 2023 +1000 gen TypeToken literal, changed cli args to match adlc commit 7d5b1e2 Author: Gary Miller <[email protected]> Date: Tue Apr 4 10:41:21 2023 +1000 gen doc comments more consistent with adlc commit 6d02bba Author: Gary Miller <[email protected]> Date: Mon Apr 3 21:25:36 2023 +1000 added optional output dir to table table data commit 059ddab Author: Gary Miller <[email protected]> Date: Mon Apr 3 21:01:58 2023 +1000 generating resolver commit 7d68841 Author: Gary Miller <[email protected]> Date: Mon Apr 3 17:07:46 2023 +1000 modify and copy ts runtime commit bf27d87 Author: Gary Miller <[email protected]> Date: Mon Apr 3 13:57:49 2023 +1000 wip: generating TS for all tests commit 55102d4 Author: Gary Miller <[email protected]> Date: Tue Mar 28 22:02:30 2023 +1100 test module names match filename, added test meta data 'testing_table.json' commit 4a679b3 Author: Gary Miller <[email protected]> Date: Tue Mar 28 21:28:41 2023 +1100 assert_module_file_err commit f7717b9 Author: Gary Miller <[email protected]> Date: Tue Mar 28 21:21:50 2023 +1100 modified rust tests to match git mv commit 5412bd4 Author: Gary Miller <[email protected]> Date: Tue Mar 28 20:41:33 2023 +1100 moved and renamed adl test files commit ea6d9bb Author: Tim Docker <[email protected]> Date: Fri Mar 24 08:31:47 2023 +1100 fix multiline doc string handling commit 95d6711 Author: Tim Docker <[email protected]> Date: Fri Mar 24 08:04:58 2023 +1100 more codegen commit 0e56f2a Author: Gary Miller <[email protected]> Date: Thu Mar 23 21:22:03 2023 +1100 tsgen localnames, primitives and type_params for union and struct underscore before unused type params fix: compiler warnings commit d3fee87 Author: Tim Docker <[email protected]> Date: Thu Mar 23 10:03:36 2023 +1100 more codegen commit 82eb63f Author: Tim Docker <[email protected]> Date: Wed Mar 22 09:26:08 2023 +1100 starting to flesh out rust codegen commit 1b59a31 Author: Tim Docker <[email protected]> Date: Tue Mar 21 22:38:42 2023 +1100 added expected rust output for test 2 commit ef2fc45 Author: Tim Docker <[email protected]> Date: Tue Mar 21 22:31:32 2023 +1100 fix resolver so that O(n) lookups now use hashing commit 9ad88b1 Merge: 4b06e95 378f21d Author: Tim Docker <[email protected]> Date: Fri Mar 17 17:15:26 2023 +1100 Merge branch 'master' into rust-tooling commit 4b06e95 Author: Gary Miller <[email protected]> Date: Fri Mar 17 13:11:33 2023 +1100 adding tim's comment on adl-lang#184 commit 2c40435 Author: Gary Miller <[email protected]> Date: Thu Mar 16 19:07:55 2023 +1100 Start of tsgen tooling commit e752e7d Author: Tim Docker <[email protected]> Date: Wed Mar 15 21:49:23 2023 +1100 fix refs to relocated adl test files commit 6064473 Author: Tim Docker <[email protected]> Date: Sun Feb 12 20:44:10 2023 +1100 generate structured rust module tree commit 476e831 Author: Tim Docker <[email protected]> Date: Sat Feb 11 22:04:18 2023 +1100 switch to using clap derive for command line parsing commit 4e4ea7c Author: Tim Docker <[email protected]> Date: Sat Feb 11 04:35:14 2023 +1100 make test adl files into top level dir, and make names consistent with module names commit 2d3f3aa Author: Tim Docker <[email protected]> Date: Sat Feb 11 04:26:54 2023 +1100 wip: rust generation commit a4328c6 Author: Gary Miller <[email protected]> Date: Tue Mar 14 18:18:08 2023 +1100 fix: 'cargo test' working commit 4efbedc Author: Tim Docker <[email protected]> Date: Fri Dec 9 14:33:20 2022 +1300 remove spans from the ast until we work out how to reconcile them with abstract loading commit a703089 Author: Tim Docker <[email protected]> Date: Fri Dec 9 08:30:16 2022 +1300 simplified error handling in resolver commit dcc79e1 Author: Tim Docker <[email protected]> Date: Fri Dec 9 08:14:47 2022 +1300 use env_logger framework commit 806f5c7 Author: Tim Docker <[email protected]> Date: Fri Dec 9 08:11:20 2022 +1300 added duplicate checks commit cdac963 Author: Tim Docker <[email protected]> Date: Thu Dec 8 22:51:01 2022 +1300 added a doc describing ADL processing steps commit 8c0a940 Author: Tim Docker <[email protected]> Date: Thu Dec 8 16:49:59 2022 +1300 include local references in emitted ast commit 8135a06 Author: Tim Docker <[email protected]> Date: Thu Dec 8 13:36:29 2022 +1300 Added an ast cli command commit c8be33c Author: Tim Docker <[email protected]> Date: Thu Dec 8 12:21:59 2022 +1300 fleshing out the resolver commit e43f444 Author: Tim Docker <[email protected]> Date: Wed Dec 7 21:43:50 2022 +1300 improved parser error messages commit 0805b16 Author: Tim Docker <[email protected]> Date: Wed Dec 7 16:08:53 2022 +1300 fleshing out verification command commit a360977 Author: Tim Docker <[email protected]> Date: Wed Dec 7 13:55:39 2022 +1300 boilerplate for a cli commit 653f15f Author: Tim Docker <[email protected]> Date: Fri Aug 19 12:35:30 2022 +1000 wip: loader commit 2ef114e Author: Tim Docker <[email protected]> Date: Thu Aug 18 17:19:27 2022 +1000 wip: resolver commit 73a45b4 Author: Tim Docker <[email protected]> Date: Tue Aug 16 09:55:03 2022 +1000 tests for apply_explicit_annotations commit 156f0c0 Author: Tim Docker <[email protected]> Date: Mon Aug 15 21:58:15 2022 +1000 implemented apply_explicit_annotations commit 1d4c6a6 Author: Tim Docker <[email protected]> Date: Mon Aug 15 20:23:14 2022 +1000 fix up warnings commit e29d2e0 Author: Tim Docker <[email protected]> Date: Mon Aug 15 20:19:39 2022 +1000 fix parsing of docstrings and annotations commit 9acb077 Author: Tim Docker <[email protected]> Date: Mon Aug 15 15:51:18 2022 +1000 parse (defunct?) decl version numbers if present commit aa5720c Author: Tim Docker <[email protected]> Date: Sun May 8 18:59:50 2022 +1000 located parsing commit 40e6c99 Author: Tim Docker <[email protected]> Date: Thu Apr 28 22:12:53 2022 +1000 Factor scratch build script commit 05b12ae Author: Tim Docker <[email protected]> Date: Wed Apr 27 11:34:04 2022 +1000 Split parser modules into separate files commit bddb2eb Author: Tim Docker <[email protected]> Date: Wed Apr 27 11:27:53 2022 +1000 Added field level annotations commit 010ed7d Author: Tim Docker <[email protected]> Date: Wed Apr 27 10:56:16 2022 +1000 Added imports to parser commit ee21025 Author: Tim Docker <[email protected]> Date: Tue Apr 26 19:02:38 2022 +1000 Added parsing of explicit annotations commit 0c2fe8e Author: Tim Docker <[email protected]> Date: Tue Apr 26 09:25:24 2022 +1000 Simplify with imports commit d2f60b1 Author: Tim Docker <[email protected]> Date: Thu Apr 21 17:27:57 2022 +1000 Annotations and docstrings commit 74203ec Author: Tim Docker <[email protected]> Date: Thu Apr 21 10:34:48 2022 +1000 Improve json string processing commit c8db1e9 Author: Tim Docker <[email protected]> Date: Thu Apr 21 08:28:23 2022 +1000 json parsing commit 9f5511f Author: Tim Docker <[email protected]> Date: Thu Apr 14 14:33:47 2022 +1000 parser fixes commit 92233db Author: Tim Docker <[email protected]> Date: Wed Apr 6 14:09:23 2022 +1000 WIP: rust parser commit b212413 Author: Tim Docker <[email protected]> Date: Sun Apr 3 15:04:22 2022 +1000 WIP: rust parser commit 6acb467 Author: Tim Docker <[email protected]> Date: Sun Apr 3 15:04:02 2022 +1000 WIP: rust parser commit 3b23dd8 Author: Tim Docker <[email protected]> Date: Sun Apr 3 14:05:03 2022 +1000 WIP: rust parser commit df8c786 Author: Tim Docker <[email protected]> Date: Sun Apr 3 10:06:49 2022 +1000 Starter project for rust tooling commit 1d818b0 Author: Tim Docker <[email protected]> Date: Sun Apr 3 15:03:31 2022 +1000 Add Debug to derived traits in rust code commit eed543b Author: Tim Docker <[email protected]> Date: Sun Apr 3 10:03:49 2022 +1000 Adding missing mapentry to published rust runtime
millergarym
added a commit
to millergarym/adl
that referenced
this pull request
May 2, 2023
commit b00e8ba Author: Gary Miller <[email protected]> Date: Tue May 2 14:15:11 2023 +1000 change release name commit 392d95e Author: Gary Miller <[email protected]> Date: Tue May 2 14:06:59 2023 +1000 reverting to a version step commit 1cc6b00 Author: Gary Miller <[email protected]> Date: Tue May 2 13:46:37 2023 +1000 looks like actions/download-artifact@v3 might be case sensative commit 8d70fe4 Author: Gary Miller <[email protected]> Date: Tue May 2 13:30:23 2023 +1000 fix rust-release.yaml commit dd18a2a Author: Gary Miller <[email protected]> Date: Tue May 2 13:25:06 2023 +1000 change actions/[email protected] and actions/[email protected] to softprops/action-gh-release@v1 commit 56695d0 Author: Gary Miller <[email protected]> Date: Tue May 2 12:33:06 2023 +1000 rust release - cache, checkout@v3, rust tooling provided commit ec8128c Author: Gary Miller <[email protected]> Date: Tue May 2 12:03:11 2023 +1000 asset_content_type: application/octet-stream commit 71c1140 Author: Gary Miller <[email protected]> Date: Tue May 2 11:34:34 2023 +1000 trim 24 chars from GITHUB_REF commit a651565 Author: Gary Miller <[email protected]> Date: Tue May 2 10:56:09 2023 +1000 commit on gm master commit ad56334 Author: Gary Miller <[email protected]> Date: Tue May 2 10:46:07 2023 +1000 rust-release.yaml commit fe6a159 Author: Gary Miller <[email protected]> Date: Tue May 2 09:36:20 2023 +1000 error on unknown fields for AdlWorkspace0 commit 976e9c3 Author: Gary Miller <[email protected]> Date: Mon May 1 19:51:33 2023 +1000 create tsconfig based on config - named_options commit 3a5ed05 Author: Gary Miller <[email protected]> Date: Mon May 1 17:13:01 2023 +1000 packagable - don't gen index.ts or write runtime's not .ts files commit 52dfa52 Author: Gary Miller <[email protected]> Date: Mon May 1 15:47:41 2023 +1000 added args for log init commit d4df193 Author: Gary Miller <[email protected]> Date: Mon May 1 11:14:48 2023 +1000 separate local and dep in resolver.ts commit bc5c6ab Author: Gary Miller <[email protected]> Date: Thu Apr 27 19:43:42 2023 +1000 unioned dir and embedded commit a09b0ca Author: Gary Miller <[email protected]> Date: Wed Apr 26 20:52:28 2023 +1000 a work version commit 9c5a401 Author: Gary Miller <[email protected]> Date: Wed Apr 26 16:57:30 2023 +1000 wip: getting typescript/workspace to work - manual edits commit 2a09c7e Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:22:22 2023 +1000 step: pnpm add -D typescript @types/node following https://brockherion.dev/blog/posts/setting-up-a-monorepo-with-pnpm-and-typescript/ commit 05f3da5 Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:21:28 2023 +1000 added gitinore at typescript/workspace commit dda2c7f Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:20:09 2023 +1000 step: pnpm init commit b50c741 Author: Gary Miller <[email protected]> Date: Wed Apr 26 13:14:26 2023 +1000 moved typescript/tests to typescript/tests/cli commit 2e2b00f Author: Gary Miller <[email protected]> Date: Mon Apr 24 23:39:51 2023 +1000 wip gen index.ts(s) commit 72067b0 Author: Gary Miller <[email protected]> Date: Mon Apr 24 11:04:05 2023 +1000 using rust_embed for ts runtime commit 9007c6f Author: Gary Miller <[email protected]> Date: Fri Apr 21 16:27:51 2023 +1000 work workspace gens commit 6cc7069 Author: Gary Miller <[email protected]> Date: Fri Apr 21 10:39:16 2023 +1000 moved annontation injection out a bit commit 020682d Author: Gary Miller <[email protected]> Date: Fri Apr 21 10:37:59 2023 +1000 modified tests needing sys.annotations, fix tsgen to check for type params withs params commit ac20a81 Author: Gary Miller <[email protected]> Date: Fri Apr 21 09:29:03 2023 +1000 move embedded_sys_loader details into packaging.adl commit c8c980e Author: Gary Miller <[email protected]> Date: Thu Apr 20 20:22:30 2023 +1000 check len type params commit cd27893 Author: Gary Miller <[email protected]> Date: Wed Apr 19 22:12:35 2023 +1000 creating package.json files commit 9743a45 Author: Gary Miller <[email protected]> Date: Wed Apr 19 17:59:59 2023 +1000 wip generating package.json(s) commit 8aa3ac5 Author: Gary Miller <[email protected]> Date: Wed Apr 19 16:04:08 2023 +1000 generating ts in folders for each adl package commit a00210b Author: Gary Miller <[email protected]> Date: Wed Apr 19 13:12:42 2023 +1000 wip commit c9545fe Author: Gary Miller <[email protected]> Date: Wed Apr 19 00:44:44 2023 +1000 injecting npm_pkg_name as annotation commit ecd01be Author: Gary Miller <[email protected]> Date: Tue Apr 18 22:56:51 2023 +1000 changed tsgen to take TypescriptGenOptions instead of TsOpts commit 0363541 Author: Gary Miller <[email protected]> Date: Tue Apr 18 21:11:06 2023 +1000 simple npm packge import commit 54d3d06 Author: Gary Miller <[email protected]> Date: Tue Apr 18 17:07:45 2023 +1000 wip : picked from -named attempt commit f4465af Author: Gary Miller <[email protected]> Date: Mon Apr 17 14:20:50 2023 +1000 fix circular ref testing commit 5c940b7 Author: Gary Miller <[email protected]> Date: Mon Apr 17 13:11:45 2023 +1000 1st working version of a workspace commit 7736092 Author: Gary Miller <[email protected]> Date: Mon Apr 17 12:07:51 2023 +1000 wip gen workspace commit db5f48a Author: Gary Miller <[email protected]> Date: Fri Apr 14 17:08:56 2023 +1000 wip on work & pkg commit 512ec6b Author: Gary Miller <[email protected]> Date: Fri Apr 14 15:02:01 2023 +1000 wip commit 9285ba4 Author: Gary Miller <[email protected]> Date: Fri Apr 14 14:44:42 2023 +1000 wip: define workspace and packaging defs commit 8658ee9 Author: Gary Miller <[email protected]> Date: Tue Apr 4 18:48:29 2023 +1000 embedded adl stdlib commit 6d44cc5 Author: Gary Miller <[email protected]> Date: Tue Apr 4 17:02:09 2023 +1000 capitalise type names commit e46f7e1 Author: Gary Miller <[email protected]> Date: Tue Apr 4 15:41:08 2023 +1000 fix rel_import commit a9d4fc7 Author: Gary Miller <[email protected]> Date: Tue Apr 4 14:39:09 2023 +1000 working for protoapp commit 2474bb4 Author: Gary Miller <[email protected]> Date: Tue Apr 4 12:31:18 2023 +1000 gen TypeToken literal, changed cli args to match adlc commit 7d5b1e2 Author: Gary Miller <[email protected]> Date: Tue Apr 4 10:41:21 2023 +1000 gen doc comments more consistent with adlc commit 6d02bba Author: Gary Miller <[email protected]> Date: Mon Apr 3 21:25:36 2023 +1000 added optional output dir to table table data commit 059ddab Author: Gary Miller <[email protected]> Date: Mon Apr 3 21:01:58 2023 +1000 generating resolver commit 7d68841 Author: Gary Miller <[email protected]> Date: Mon Apr 3 17:07:46 2023 +1000 modify and copy ts runtime commit bf27d87 Author: Gary Miller <[email protected]> Date: Mon Apr 3 13:57:49 2023 +1000 wip: generating TS for all tests commit 55102d4 Author: Gary Miller <[email protected]> Date: Tue Mar 28 22:02:30 2023 +1100 test module names match filename, added test meta data 'testing_table.json' commit 4a679b3 Author: Gary Miller <[email protected]> Date: Tue Mar 28 21:28:41 2023 +1100 assert_module_file_err commit f7717b9 Author: Gary Miller <[email protected]> Date: Tue Mar 28 21:21:50 2023 +1100 modified rust tests to match git mv commit 5412bd4 Author: Gary Miller <[email protected]> Date: Tue Mar 28 20:41:33 2023 +1100 moved and renamed adl test files commit ea6d9bb Author: Tim Docker <[email protected]> Date: Fri Mar 24 08:31:47 2023 +1100 fix multiline doc string handling commit 95d6711 Author: Tim Docker <[email protected]> Date: Fri Mar 24 08:04:58 2023 +1100 more codegen commit 0e56f2a Author: Gary Miller <[email protected]> Date: Thu Mar 23 21:22:03 2023 +1100 tsgen localnames, primitives and type_params for union and struct underscore before unused type params fix: compiler warnings commit d3fee87 Author: Tim Docker <[email protected]> Date: Thu Mar 23 10:03:36 2023 +1100 more codegen commit 82eb63f Author: Tim Docker <[email protected]> Date: Wed Mar 22 09:26:08 2023 +1100 starting to flesh out rust codegen commit 1b59a31 Author: Tim Docker <[email protected]> Date: Tue Mar 21 22:38:42 2023 +1100 added expected rust output for test 2 commit ef2fc45 Author: Tim Docker <[email protected]> Date: Tue Mar 21 22:31:32 2023 +1100 fix resolver so that O(n) lookups now use hashing commit 9ad88b1 Merge: 4b06e95 378f21d Author: Tim Docker <[email protected]> Date: Fri Mar 17 17:15:26 2023 +1100 Merge branch 'master' into rust-tooling commit 4b06e95 Author: Gary Miller <[email protected]> Date: Fri Mar 17 13:11:33 2023 +1100 adding tim's comment on adl-lang#184 commit 2c40435 Author: Gary Miller <[email protected]> Date: Thu Mar 16 19:07:55 2023 +1100 Start of tsgen tooling commit e752e7d Author: Tim Docker <[email protected]> Date: Wed Mar 15 21:49:23 2023 +1100 fix refs to relocated adl test files commit 6064473 Author: Tim Docker <[email protected]> Date: Sun Feb 12 20:44:10 2023 +1100 generate structured rust module tree commit 476e831 Author: Tim Docker <[email protected]> Date: Sat Feb 11 22:04:18 2023 +1100 switch to using clap derive for command line parsing commit 4e4ea7c Author: Tim Docker <[email protected]> Date: Sat Feb 11 04:35:14 2023 +1100 make test adl files into top level dir, and make names consistent with module names commit 2d3f3aa Author: Tim Docker <[email protected]> Date: Sat Feb 11 04:26:54 2023 +1100 wip: rust generation commit a4328c6 Author: Gary Miller <[email protected]> Date: Tue Mar 14 18:18:08 2023 +1100 fix: 'cargo test' working commit 4efbedc Author: Tim Docker <[email protected]> Date: Fri Dec 9 14:33:20 2022 +1300 remove spans from the ast until we work out how to reconcile them with abstract loading commit a703089 Author: Tim Docker <[email protected]> Date: Fri Dec 9 08:30:16 2022 +1300 simplified error handling in resolver commit dcc79e1 Author: Tim Docker <[email protected]> Date: Fri Dec 9 08:14:47 2022 +1300 use env_logger framework commit 806f5c7 Author: Tim Docker <[email protected]> Date: Fri Dec 9 08:11:20 2022 +1300 added duplicate checks commit cdac963 Author: Tim Docker <[email protected]> Date: Thu Dec 8 22:51:01 2022 +1300 added a doc describing ADL processing steps commit 8c0a940 Author: Tim Docker <[email protected]> Date: Thu Dec 8 16:49:59 2022 +1300 include local references in emitted ast commit 8135a06 Author: Tim Docker <[email protected]> Date: Thu Dec 8 13:36:29 2022 +1300 Added an ast cli command commit c8be33c Author: Tim Docker <[email protected]> Date: Thu Dec 8 12:21:59 2022 +1300 fleshing out the resolver commit e43f444 Author: Tim Docker <[email protected]> Date: Wed Dec 7 21:43:50 2022 +1300 improved parser error messages commit 0805b16 Author: Tim Docker <[email protected]> Date: Wed Dec 7 16:08:53 2022 +1300 fleshing out verification command commit a360977 Author: Tim Docker <[email protected]> Date: Wed Dec 7 13:55:39 2022 +1300 boilerplate for a cli commit 653f15f Author: Tim Docker <[email protected]> Date: Fri Aug 19 12:35:30 2022 +1000 wip: loader commit 2ef114e Author: Tim Docker <[email protected]> Date: Thu Aug 18 17:19:27 2022 +1000 wip: resolver commit 73a45b4 Author: Tim Docker <[email protected]> Date: Tue Aug 16 09:55:03 2022 +1000 tests for apply_explicit_annotations commit 156f0c0 Author: Tim Docker <[email protected]> Date: Mon Aug 15 21:58:15 2022 +1000 implemented apply_explicit_annotations commit 1d4c6a6 Author: Tim Docker <[email protected]> Date: Mon Aug 15 20:23:14 2022 +1000 fix up warnings commit e29d2e0 Author: Tim Docker <[email protected]> Date: Mon Aug 15 20:19:39 2022 +1000 fix parsing of docstrings and annotations commit 9acb077 Author: Tim Docker <[email protected]> Date: Mon Aug 15 15:51:18 2022 +1000 parse (defunct?) decl version numbers if present commit aa5720c Author: Tim Docker <[email protected]> Date: Sun May 8 18:59:50 2022 +1000 located parsing commit 40e6c99 Author: Tim Docker <[email protected]> Date: Thu Apr 28 22:12:53 2022 +1000 Factor scratch build script commit 05b12ae Author: Tim Docker <[email protected]> Date: Wed Apr 27 11:34:04 2022 +1000 Split parser modules into separate files commit bddb2eb Author: Tim Docker <[email protected]> Date: Wed Apr 27 11:27:53 2022 +1000 Added field level annotations commit 010ed7d Author: Tim Docker <[email protected]> Date: Wed Apr 27 10:56:16 2022 +1000 Added imports to parser commit ee21025 Author: Tim Docker <[email protected]> Date: Tue Apr 26 19:02:38 2022 +1000 Added parsing of explicit annotations commit 0c2fe8e Author: Tim Docker <[email protected]> Date: Tue Apr 26 09:25:24 2022 +1000 Simplify with imports commit d2f60b1 Author: Tim Docker <[email protected]> Date: Thu Apr 21 17:27:57 2022 +1000 Annotations and docstrings commit 74203ec Author: Tim Docker <[email protected]> Date: Thu Apr 21 10:34:48 2022 +1000 Improve json string processing commit c8db1e9 Author: Tim Docker <[email protected]> Date: Thu Apr 21 08:28:23 2022 +1000 json parsing commit 9f5511f Author: Tim Docker <[email protected]> Date: Thu Apr 14 14:33:47 2022 +1000 parser fixes commit 92233db Author: Tim Docker <[email protected]> Date: Wed Apr 6 14:09:23 2022 +1000 WIP: rust parser commit b212413 Author: Tim Docker <[email protected]> Date: Sun Apr 3 15:04:22 2022 +1000 WIP: rust parser commit 6acb467 Author: Tim Docker <[email protected]> Date: Sun Apr 3 15:04:02 2022 +1000 WIP: rust parser commit 3b23dd8 Author: Tim Docker <[email protected]> Date: Sun Apr 3 14:05:03 2022 +1000 WIP: rust parser commit df8c786 Author: Tim Docker <[email protected]> Date: Sun Apr 3 10:06:49 2022 +1000 Starter project for rust tooling commit 1d818b0 Author: Tim Docker <[email protected]> Date: Sun Apr 3 15:03:31 2022 +1000 Add Debug to derived traits in rust code commit eed543b Author: Tim Docker <[email protected]> Date: Sun Apr 3 10:03:49 2022 +1000 Adding missing mapentry to published rust runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.