Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing uni4E08uE0101-JP for Adobe-Japan1 compatibility #434

Open
NightFurySL2001 opened this issue Jul 9, 2023 · 4 comments
Open

Missing uni4E08uE0101-JP for Adobe-Japan1 compatibility #434

NightFurySL2001 opened this issue Jul 9, 2023 · 4 comments

Comments

@NightFurySL2001
Copy link

NightFurySL2001 commented Jul 9, 2023

During the conversion from static release (v2.002) to variable font release (v2.003 and current v2.004), the glyph for uni4E08uE0101-JP (CID+62067) is removed from the glyphset. This has caused the aj16-kanji.txt to miss the glyph uni4E08uE0101-JP at CID+13463.

The glyph for uni4E08uE0101-JP is probably kept for compatibility with Adobe-Japan1 as mentioned in #98 (comment) and should be restored.

Edit

Also, for better aesthetics, suggest to revert the glyph in v2.002 to v1 U+E0101 glyph where the character face is more compact and fitting to other characters. The CN glyph should be replaced with JP too.
v1:
image

v2.002:
image

@punchcutter
Copy link
Member

The glyph is there. It's in the file at CID+62067, the IVS is in the CMap, the glyph is in aj16-kanji.txt at CID+13463. The only thing that got messed up for some strange reason is the layout file. I'm not really sure how that happened, but it's already been fixed for a while so it will be in the next release.

@NightFurySL2001
Copy link
Author

I see, thank you. Verified that CID+62067 does have the glyph in place, just the AI0 file is messed up. I do have to re-run a rebuild now though....

@NightFurySL2001
Copy link
Author

Keyword: U+4E08 U+E0101, uni4E08 uniE0101, 丈, 丈󠄁

for GitHub search to have a better chance to detect this issue.

@Marcus98T
Copy link

Marcus98T commented Mar 28, 2024

It was mentioned that the uni4E08uE0101-JP glyph was made identical to the CN glyph in v2.002 of Source Han Sans, hence the current mess-up. Also referencing one of my other issues with ugly CN glyph design, I'm leaning towards trying to balance the proportions between the unreleased JP/removed v1 JP variant glyph and the CN glyph, but the glyph should be named uni4E08-JP. Then the adjusted shape can be used for the uni4E08uE0101-JP glyph as well.

Character Glyph Name Description
U+4E08 丈 uni4E08uE0101-JP Make the glyph identical to the CN glyph, uni4E08-CN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants