Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround: @oclif/core in @oclif/plugins-plugin@^2.x is not compatible with node-14 #468

Closed
wants to merge 4 commits into from

Conversation

shazron
Copy link
Member

@shazron shazron commented Jul 13, 2023

Closes #466

Motivation and Context

Make every PR pass again.

How Has This Been Tested?

the CI is the test.
manually tested also.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #468 (bd258b2) into master (d710269) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #468   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          238       238           
  Branches        47        47           
=========================================
  Hits           238       238           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron
Copy link
Member Author

shazron commented Jul 13, 2023

Turns out npm ci has issues with the overrides key in package.json 😭 npm/cli#4942 (npm install is fine)

@shazron shazron force-pushed the oclif-core-overrides branch from 6d5a0da to bd258b2 Compare July 13, 2023 02:10
@shazron shazron closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@oclif/[email protected] is breaking our dependencies since it uses Node 16 features (with no major bump)
1 participant