Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if we are setting jdkDate correctly for both types of JDK implementations #888

Open
smlambert opened this issue Jun 27, 2024 · 1 comment · May be fixed by #890
Open

Check if we are setting jdkDate correctly for both types of JDK implementations #888

smlambert opened this issue Jun 27, 2024 · 1 comment · May be fixed by #890
Labels
soc_24

Comments

@smlambert
Copy link
Contributor

We parse the contents of the output of java -version to set jdkDate (which is meant to indicate build date as opposed to some future release date) in this block of code: https://github.com/adoptium/aqa-test-tools/blob/master/TestResultSummaryService/parsers/Parser.js#L12-L33

Output from java -version is quite different depending on what jdk implementation is used.

hotspot impls look like:

16:38:54  =JAVA VERSION OUTPUT BEGIN=
16:38:54  openjdk version "21.0.4-beta" 2024-07-16
16:38:54  OpenJDK Runtime Environment Temurin-21.0.4+6-202406261902 (build 21.0.4-beta+6-ea)
16:38:54  OpenJDK 64-Bit Server VM Temurin-21.0.4+6-202406261902 (build 21.0.4-beta+6-ea, mixed mode, sharing)
16:38:54  =JAVA VERSION OUTPUT END=

openj9 impls look like:

11:53:15  =JAVA VERSION OUTPUT BEGIN=
11:53:19  openjdk version "11.0.24-internal" 2024-07-16
11:53:19  OpenJDK Runtime Environment (build 11.0.24-internal+0-adhoc.jenkins.BuildJDK11aarch64macPersonal)
11:53:19  Eclipse OpenJ9 VM (build master-2a2df9f1117, JRE 11 Mac OS X aarch64-64-Bit 20240627_514 (JIT enabled, AOT enabled)
11:53:19  OpenJ9   - 2a2df9f1117
11:53:19  OMR      - 47a9d248db0
11:53:19  JCL      - c535515f053 based on jdk-11.0.24+6)
11:53:19  =JAVA VERSION OUTPUT END=

See related comments after adoptium/temurin-build#1456 (comment)
@Sangyoon21 Sangyoon21 linked a pull request Jul 13, 2024 that will close this issue
Open
@llxia
Copy link
Contributor

llxia commented Jul 23, 2024

Note: some Temurin builds do not have any date. This should be fixed.

03:22:52  =JAVA VERSION OUTPUT BEGIN=
03:22:52  openjdk version "1.8.0_412"
03:22:52  OpenJDK Runtime Environment (Temurin)(build 1.8.0_412-b08)
03:22:52  OpenJDK 64-Bit Server VM (Temurin)(build 25.412-b08, mixed mode)
03:22:52  =JAVA VERSION OUTPUT END=

https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.functional_x86-64_alpine-linux/312/consoleFull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
soc_24
Projects
Adoptium Backlog
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Making the correct Parsing Sangyoon21/aqa-test-tools
2 participants
@smlambert @llxia