Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDependencies.pl customUrl should not hardcode to https://ci.adoptium.net #5286

Closed
llxia opened this issue May 7, 2024 · 3 comments
Closed

getDependencies.pl customUrl should not hardcode to https://ci.adoptium.net #5286

llxia opened this issue May 7, 2024 · 3 comments
Labels
enhancement

Comments

@llxia
Copy link
Contributor

llxia commented May 7, 2024 •
edited
Loading

getDependencies.pl customUrl should not hardcode to https://ci.adoptium.net Jenkins. We should change it based on the Jenkins domain:

aqa-tests/buildenv/jenkins/JenkinsfileBase

Line 210 in 9639787

def customUrl = "https://ci.adoptium.net/job/test.getDependency/lastSuccessfulBuild/artifact/"

We can leverage the following for Jenkins domain value:

aqa-tests/buildenv/jenkins/JenkinsfileBase

Line 1046 in 9639787

def getJenkinsDomain() {

This allows each vendor to adjust test.getDependency job if needed.

related: #5283 (comment)
@llxia
Copy link
Contributor Author

llxia commented May 7, 2024

@annaibm please take a look. Thanks

annaibm added a commit to annaibm/aqa-tests that referenced this issue May 7, 2024
@annaibm
Update customUrl to dynamically use Jenkins domain
e3fe87b 
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <[email protected]>
@llxia
Copy link
Contributor Author

llxia commented May 7, 2024 •
edited
Loading

@annaibm I just remembered that we would not be able to access the Jenkins URL if anonymous access is not allowed. This was one of the reasons that we set Adoptium jenkins URL in the first place. Please add the check:

if JenkinsDomain contains `hyc-runtimes`
   use openj9 Jenkins
else
    use JenkinsDomain

annaibm added a commit to annaibm/aqa-tests that referenced this issue May 7, 2024
@annaibm
Update customUrl to dynamically use Jenkins domain
b892202 
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue May 7, 2024
@annaibm
Update customUrl to dynamically use Jenkins domain
c348a98 
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm mentioned this issue May 7, 2024
Merged
annaibm added a commit to annaibm/aqa-tests that referenced this issue May 7, 2024
@annaibm
Update customUrl to dynamically use Jenkins domain
a4cefa1 
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <[email protected]>
@llxia llxia mentioned this issue May 7, 2024
Closed
annaibm added a commit to annaibm/aqa-tests that referenced this issue May 7, 2024
@annaibm
Update customUrl to dynamically use Jenkins domain
1f43615 
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue May 15, 2024
@annaibm
Update customUrl to dynamically use Jenkins domain
e8887c6 
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <[email protected]>
karianna pushed a commit that referenced this issue May 16, 2024
@annaibm
Update customUrl to dynamically use Jenkins domain (#5289)
5685ea4 
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:#5286

Signed-off-by: Anna Babu Palathingal <[email protected]>
@andrew-m-leonard andrew-m-leonard mentioned this issue Sep 11, 2024
Closed
@llxia
Copy link
Contributor Author

llxia commented Dec 4, 2024

resolved via #5289

@llxia llxia closed this as completed Dec 4, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Adoptium Backlog Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Adoptium Backlog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@llxia