Exclude failing CDS tests on jdk17u mac-x64 as Temurin does not build a CDS #5878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Leonard <[email protected]>
sxa
reviewed
Jan 17, 2025
sxa
approved these changes
Jan 17, 2025
Correct, multiple bug URL's is not supported and in fact I think causes the exclude line to be invalid |
smlambert
approved these changes
Jan 17, 2025
andrew-m-leonard
added a commit
to andrew-m-leonard/aqa-tests
that referenced
this pull request
Jan 17, 2025
Signed-off-by: Andrew Leonard <[email protected]>
smlambert
pushed a commit
that referenced
this pull request
Jan 17, 2025
Signed-off-by: Andrew Leonard <[email protected]>
Yes, upstream tooling only supports 1 entry per testcase, so if there are multiple entries, only the last one is honoured (earlier ones ignored), so we've decided to take this approach to understand which issues relate to which platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't build a CDS on Mac x64 (ref: adoptium/adoptium-support#937 (comment))
There are some tests not excluded on jdk17u for mac x64.
Note: jdk21+ excludes all CDS tests when no-CDS ref: https://github.com/openjdk/jdk21u/blob/e45287d1ad9dcadf8a23d3271f1b675b8dade0ac/test/hotspot/jtreg/TEST.groups#L56