Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure JavaTestRunner fileURL on Windows uses forward slashes #4172

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

andrew-m-leonard
Copy link
Contributor

Ensure JavaTestRunner on Windows uses a fileURL that is valid for java.net.URI, which the framework validates with.

Signed-off-by: Andrew Leonard [email protected]

@andrew-m-leonard andrew-m-leonard self-assigned this Nov 29, 2022
@andrew-m-leonard
Copy link
Contributor Author

Test grinder for jck-runtime-api-java_net_0 passes.

@andrew-m-leonard
Copy link
Contributor Author

@Mesbah-Alam This may possibly fix for openj9 too?

<platform>ppc64_aix|x86-64_mac|x86-64_windows|x86-32_windows</platform>

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit 09614e3 into adoptium:master Nov 29, 2022
@Mesbah-Alam
Copy link
Contributor

@andrew-m-leonard , I had missed your comment in #4172 (comment) : Actually, we had disabled jck-runtime-api-java_net due to various intermittent failures (details in the related backlog issues listed in the excludes) observed over a period of time. It is currently run by the CR team manually on the excluded platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants