Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TEST_IMAGES_REQUIRED and DEBUG_IMAGES_REQUIRED for openj9 nightly #4182

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Support TEST_IMAGES_REQUIRED and DEBUG_IMAGES_REQUIRED for openj9 nightly #4182

merged 1 commit into from
Dec 5, 2022

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Dec 5, 2022 •
edited
Loading

related: #3957
Signed-off-by: Lan Xia [email protected]

@llxia
Copy link
Contributor Author

llxia commented Dec 5, 2022

  • set both TEST_IMAGES_REQUIRED and DEBUG_IMAGES_REQUIRED to false: Grinder/29973/
  • set both TEST_IMAGES_REQUIRED and DEBUG_IMAGES_REQUIRED to true:Grinder/29974
  • set TEST_IMAGES_REQUIRED to true and DEBUG_IMAGES_REQUIRED to false: Grinder/29975

@llxia llxia marked this pull request as ready for review December 5, 2022 15:18
@llxia llxia requested review from renfeiw and LongyuZhang December 5, 2022 15:19
renfeiw
renfeiw approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LongyuZhang
LongyuZhang approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit a74405c into adoptium:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@renfeiw renfeiw renfeiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llxia @renfeiw @LongyuZhang