Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for the SPECjbb perf testing benchmark #4363

Merged
merged 29 commits into from
Mar 7, 2023

Conversation

ahmedmuhsin
Copy link
Contributor

Initial support for SPECjbb will allow users who already have a licensed local copy of the benchmark to launch a simple run in multi-jvm mode from within aqa-test.

Please see perf/specjbb/README.md for instructions on how to use this feature.

@ahmedmuhsin ahmedmuhsin changed the title Specjbb initial support Initial support for the SPECjbb perf testing benchmark Feb 23, 2023
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if shellcheck was run, but if not then that's worth doing so as well.

perf/specjbb/README.md Outdated Show resolved Hide resolved
perf/specjbb/README.md Outdated Show resolved Hide resolved
perf/specjbb/README.md Show resolved Hide resolved
perf/specjbb/run/run_multi.sh Outdated Show resolved Hide resolved
perf/specjbb/run/run_multi.sh Outdated Show resolved Hide resolved
perf/specjbb/run/run_multi.sh Show resolved Hide resolved
gdams and others added 2 commits March 2, 2023 09:43
* update SpecJBB job from initial TRSS testing

* fix bug

* fixup

* rewrite getSpecjbbSuite.sh using antfile
@gdams
Copy link
Member

gdams commented Mar 2, 2023

@smlambert I think this is in a good state now, one initial thought is what would be the best way to skip this when the specJBB material isn’t available? E.g can we skip on Temurin but run elsewhere?

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few of my comments left to go, but none are blockers so I'm approving

perf/specjbb/README.md Outdated Show resolved Hide resolved
perf/specjbb/playlist.xml Show resolved Hide resolved
perf/specjbb/playlist.xml Outdated Show resolved Hide resolved
perf/specjbb/playlist.xml Show resolved Hide resolved
perf/specjbb/README.md Outdated Show resolved Hide resolved
ahmedmuhsin and others added 3 commits March 6, 2023 15:33
Co-authored-by: Shelley Lambert <[email protected]>
…y test to run as part of AQAvit verification

Co-authored-by: Shelley Lambert <[email protected]>
Co-authored-by: Shelley Lambert <[email protected]>
@ahmedmuhsin ahmedmuhsin force-pushed the specjbb-initial-support branch from 6111d45 to d06909c Compare March 6, 2023 22:20
@ahmedmuhsin ahmedmuhsin requested a review from gdams March 6, 2023 22:23
@gdams gdams requested a review from smlambert March 7, 2023 16:17
@karianna karianna merged commit 43354d1 into adoptium:master Mar 7, 2023
@Mesbah-Alam
Copy link
Contributor

This PR seems incomplete and it breaks the internal perf test build compilation due to SPECJBB_SRC not being defined (ref: backlog/issues/1051).

From README of this PR :

Set the `SPECJBB_SRC` environment variable to the absolute path of your SPECjbb benchmark directory

This test is assuming ${env.SPECJBB_SRC}/specjbb2015.jar will be pre-staged on the machine where it will run and that SPECJBB_SRC will point to it.

Error detail:

23:03:45  printInput:
23:03:45       [echo] SPECJBB_SRC ${env.SPECJBB_SRC}
23:03:45       [echo] SPECJBB_DEST C:/Users/jenkins/workspace/Test_openjdk8_j9_sanity.perf_x86-32_windows/aqa-tests///..//jvmtest/perf/specjbb/suite
23:03:45       [echo] SPECJBB_JAR specjbb2015.jar
23:03:45       [echo] JAVA_BIN C:/Users/jenkins/workspace/Test_openjdk8_j9_sanity.perf_x86-32_windows/openjdkbinary/j2sdk-image/bin/java
23:03:45  
23:03:45  srcIsValid:
23:03:45       [echo] ##### Validating source SPECjbb dir
23:03:45  
23:03:45  dirIsValid:
23:03:45  
23:03:45  exists:
23:03:45  
23:03:45  isRunnable:
23:03:45       [exec] Error: Unable to access jarfile ${env.SPECJBB_SRC}/specjbb2015.jar
23:03:45       [exec] Result: 1
23:03:45  

@gdams
Copy link
Member

gdams commented Mar 14, 2023

@Mesbah-Alam this issue was fixed in 3c48ef4, does IBM have this patch internally?

@Mesbah-Alam
Copy link
Contributor

Hi @gdams , thanks for the info. The failing internal build (launched on March 9th) had missed this fix. Will monitor the next one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants