Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK21 add jdk_tools_openj9_DynamicLoadWarningTest #4735

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

JasonFengJ9
Copy link
Contributor

@JasonFengJ9 JasonFengJ9 commented Aug 29, 2023

JDK21 add jdk_tools_openj9_DynamicLoadWarningTest

This is to run com/sun/tools/attach/warnings/DynamicLoadWarningTest.java test for OpenJ9/IBM JDK21+.

Instead of enablingjdk_tools and disabling other tests except com/sun/tools/attach/warnings/DynamicLoadWarningTest.java, this PR adds jdk_tools_openj9_DynamicLoadWarningTest to run this test only.

An internal grinder

Related to

Signed-off-by: Jason Feng [email protected]

@JasonFengJ9
Copy link
Contributor Author

@llxia @LongyuZhang could you please review?
FYI @smlambert

@smlambert smlambert requested a review from llxia August 29, 2023 16:35
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

openjdk/playlist.xml Outdated Show resolved Hide resolved
This is to run com/sun/tools/attach/warnings/DynamicLoadWarningTest.java
test for OpenJ9/IBM JDK21+.

Signed-off-by: Jason Feng <[email protected]>
@JasonFengJ9 JasonFengJ9 force-pushed the DynamicLoadWarningTest branch from ec7dd84 to b034af5 Compare August 30, 2023 12:55
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 53cc06d into adoptium:master Aug 30, 2023
@JasonFengJ9 JasonFengJ9 deleted the DynamicLoadWarningTest branch August 30, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants