Fix concurrency on non-cgroups linux #4792
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a bug in the logic when detecting the amount of RAM available on a Linux machine which does not have cgroups enabled.
In this case, the amount of RAM is coming back in GB instead of MB so ends up looking very small when the concurrency calculation is performed. This should resolve it, however it needs to be checked on more machines since I found that
/sys/fs/cgroup/memory/memory.limit_in_bytes
on one of out Linux/ppc64le machines (test-osuosl-ubuntu1604-ppc64le-2
) was9223372036854710272
which doesn't seem right.Fixing this has the potential to dramatically decrease the openjdk test job times on some Linux machines (Spotted on RISC-V)