-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow enhancement to handle Git failures #4806
Conversation
Here are test runs for the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would recommend a better commit comment. You have linked to an internal IBM issue which nobody outside of IBM will be able to see. Your commit comment should explain what you're changing and why. This repo has a contributing.md (here). I try to follow, and by default I direct people to OpenJ9's guidelines on commit comments. You will thank yourself later when you're scrolling through the history trying to track down a change. |
2466f9f
to
95a219b
Compare
- fixes issue of corrupted git directory resulting in test failure
dd22e90
to
289f5e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this only handle the issue where the .git
dir is missing? I was originally thinking it would cover all cases where the git update fails.
This PR will check the first git cmd, that is I think we should get this change in to ease the problems. Meanwhile, working on a solution to handle all git cases. To be honest, I think we should re-write the logic in this file. btw, If the material is in a bad state (i.e., jenkins user cannot delete the material), there is not much we can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- fixes issue of corrupted git directory resulting in test failure Co-authored-by: Kapil Powar <[email protected]>
- fixes issue of corrupted git directory resulting in test failure Co-authored-by: Kapil Powar <[email protected]>
- fixes issue of corrupted git directory resulting in test failure Co-authored-by: Kapil Powar <[email protected]>
runtimes/backlog/issues/1184
Update test workflow to handle Git failures.
Signed-off-by: Kapil Powar [email protected]
CC: @llxia