Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine concurrency logic #5063

Merged
merged 8 commits into from
Feb 16, 2024

Commits on Feb 5, 2024

  1. Fix for unchecked concurrency

    We need to make sure we're not using so many cores that the tests
    are starved of memory.
    
    Signed-off-by: Adam Farley <[email protected]>
    adamfarley committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    cda0149 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Adjusting memory size math to compare bytes with bytes

    Instead of what it does right now, which is to compare bytes with
    kilobytes, and incorrectly assume that the kilobytes number is always
    smaller.
    
    Signed-off-by: Adam Farley <[email protected]>
    adamfarley committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    61a56c4 View commit details
    Browse the repository at this point in the history
  2. Updating memory limit check to allow cgroup V2 compatability

    In cgroup v1 we used memory.limit_in_bytes to store the maximum
    memory allocated to the container. In v2, we use memory.max. This
    change allows us to check for both, includes a meminfo check for
    non-containers, and adds a few debug comments so we can be sure this
    new code is working.
    
    My plan is to run tests on a diverse set of machines, and to remove
    the debug statements prior to merging.
    
    Signed-off-by: Adam Farley <[email protected]>
    adamfarley committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    54baab1 View commit details
    Browse the repository at this point in the history
  3. Include docker check and cgroup version check

    To ensure we're looking in the correct file for the maximum memory
    size. Also to handle permissions issues, empty files, etc.
    
    Signed-off-by: Adam Farley <[email protected]>
    adamfarley committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    7b6dc17 View commit details
    Browse the repository at this point in the history
  4. Exporting debug message

    Signed-off-by: Adam Farley <[email protected]>
    adamfarley committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    65ec46d View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Switching back to file existance checks for simplicity

    Makes it easier to maintain, and more resilient to failure.
    
    I've also added a commented, formatted copy of the script to help
    people read it in the future.
    
    Signed-off-by: Adam Farley <[email protected]>
    adamfarley committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ef689c4 View commit details
    Browse the repository at this point in the history
  2. Correcting comment symbol. Typo.

    Signed-off-by: Adam Farley <[email protected]>
    adamfarley committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    2ec2b02 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Switching to curley braces to access variable value

    Signed-off-by: Adam Farley <[email protected]>
    adamfarley committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    923e67e View commit details
    Browse the repository at this point in the history