Do not move the test to child job if parallel list number=1 #5511
Conversation
|
https://ci.adoptium.net/job/Test_openjdk23_hs_special.system_x86-64_linux/12/ - no child job is triggered if the generated test list is equal = 1. child rerun job failure is expected, which can't set personal ADOPTOPENJDK_REPO #4585 |
sophia-guo
force-pushed
the
rerun
branch
2 times, most recently
from
298a576 to
3165781
Compare
Signed-off-by: Sophia Guo <[email protected]>
| @@ -969,7 +973,10 @@ def testBuild() { | |||
| // prepare environment and compile test projects | |||
| if ((params.PARALLEL == "NodesByIterations" && NUM_MACHINES > 1) | |||
| || (params.PARALLEL == "Dynamic" && (NUM_MACHINES > 1 || (params.TEST_TIME && !params.NUM_MACHINES)))) { | |||
| setupParallelEnv() | |||
| if (setupParallelEnv() == 1) { | |||
| // No need to run tests in parallel | |||
There was a problem hiding this comment.
Do we want to echo here as well?
There was a problem hiding this comment.
Yes, it is echoed https://github.com/adoptium/aqa-tests/pull/5511/files#diff-21a56f751656da4e3e5abee13913f51a269d6eb43235bc16fc4be21ef70deaf2R260
16:32:34 Number of test list is 1, no need to run tests in child job.
|
thanks @sophia-guo - we have already branched for Sept release, could this also be cherrypicked to v1.0.3-release branch please. |
…#5511) Signed-off-by: Sophia Guo <[email protected]>
…5517) Signed-off-by: Sophia Guo <[email protected]>
| @@ -315,7 +319,7 @@ def setupParallelEnv() { | |||
| if (create_jobs) { | |||
| parallel create_jobs | |||
| } | |||
|
|
|||
| return NUM_LIST | |||
There was a problem hiding this comment.
The variable NUM_LIST is not visible here (it's confined to the scope where it's declared, which ends on line 265); our test builds are failing as a result:
00:15:35.923 Exception: groovy.lang.MissingPropertyException: No such property: NUM_LIST for class: Script1
Close #5375