Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude jdk_beans subtests for OpenJ9 #5790

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Dec 3, 2024

  • Exclude jdk_beans subtests for OpenJ9

related: eclipse-openj9/openj9#20531

java/beans/PropertyEditor/TestFontClassJava.java https://bugs.openjdk.java.net/browse/JDK-8173082 macosx-all
java/beans/PropertyEditor/TestFontClassNull.java https://bugs.openjdk.java.net/browse/JDK-8173082 macosx-all
java/beans/PropertyEditor/TestFontClassValue.java https://bugs.openjdk.java.net/browse/JDK-8173082 macosx-all
java/beans/XMLEncoder/java_awt_ScrollPane.java https://github.com/adoptium/aqa-tests/issues/2848 macosx-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2810 was moved to Adoptium infra repo #2810 (comment)

If we have this issue in hyc, maybe we should open an infra issue internally.

Copy link
Contributor Author

@annaibm annaibm Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove java/beans/XMLEncoder/java_awt_ScrollPane.java (related to adoptium/aqa-tests#2848 for macosx-all) and double-check if the issue occurs in HYC. If it does, I will open an internal infrastructure issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to test this on Openj9 Jenkins

Comment on lines 21 to 30
java/beans/PropertyEditor/6380849/TestPropertyEditor.java https://github.com/adoptium/aqa-tests/issues/117 macosx-all
java/beans/PropertyEditor/TestColorClass.java https://github.com/adoptium/aqa-tests/issues/117 macosx-all
java/beans/PropertyEditor/TestColorClassJava.java https://github.com/adoptium/aqa-tests/issues/117 macosx-all
java/beans/PropertyEditor/TestColorClassNull.java https://github.com/adoptium/aqa-tests/issues/117 macosx-all
java/beans/PropertyEditor/TestColorClassValue.java https://github.com/adoptium/aqa-tests/issues/117 macosx-all
java/beans/PropertyEditor/TestFontClass.java https://github.com/adoptium/aqa-tests/issues/117 macosx-all
java/beans/PropertyEditor/TestFontClassJava.java https://github.com/adoptium/aqa-tests/issues/117 macosx-all
java/beans/PropertyEditor/TestFontClassNull.java https://github.com/adoptium/aqa-tests/issues/117 macosx-all
java/beans/PropertyEditor/TestFontClassValue.java https://github.com/adoptium/aqa-tests/issues/117 macosx-all
java/beans/XMLEncoder/java_awt_ScrollPane.java https://github.com/adoptium/aqa-tests/issues/117 macosx-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar reason. We should not reference the Adoptium infra issue for openj9 test failure.

@annaibm annaibm force-pushed the excludeJdk_beansTests branch 3 times, most recently from 1ff14bc to 5432d52 Compare December 4, 2024 17:04
@llxia
Copy link
Contributor

llxia commented Dec 4, 2024

Please update the PR title and commit title to Exclude jdk_beans subtests for OpenJ9

@annaibm annaibm changed the title Exclude jdk_beans subtests as excluded in Adoptium Exclude jdk_beans subtests for OpenJ9 Dec 4, 2024
- Exclude jdk_beans subtests for OpenJ9

related: eclipse-openj9/openj9#20531

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm force-pushed the excludeJdk_beansTests branch from 5432d52 to be95f82 Compare December 4, 2024 18:39
@annaibm annaibm marked this pull request as ready for review December 4, 2024 18:56
java/beans/PropertyEditor/TestFontClassNull.java https://bugs.openjdk.java.net/browse/JDK-8173082 macosx-all
java/beans/PropertyEditor/TestFontClassValue.java https://bugs.openjdk.java.net/browse/JDK-8173082 macosx-all
java/beans/XMLEncoder/java_awt_ScrollPane.java https://github.com/adoptium/aqa-tests/issues/2848 macosx-all
java/beans/Beans/TypoInBeanDescription.java https://github.com/eclipse-openj9/openj9/issues/20531 macosx-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypoInBeanDescription passed in the xmac Grinder

@llxia
Copy link
Contributor

llxia commented Dec 5, 2024

https://bugs.openjdk.java.net/browse/JDK-8173082 is fixed. The affected tests should pass now.

For example, TestColorClass* passed in xmac Grinder

@llxia llxia marked this pull request as draft December 5, 2024 15:53
@llxia
Copy link
Contributor

llxia commented Dec 5, 2024

Convert this PR to draft as it is not ready yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants