Correct URL for STF repo #3023
Merged
Correct URL for STF repo #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith W. Campbell <[email protected]>
|
The proper fix is to update the git repo when running the tests and update test scripts that expecting lowercase stf. The issue is opened at #2949. By changing values in testenv.properties, will cause the test scripts to fail in execution as they are still expecting lowercase stf. Also, testenv.properties will be auto-generated in the near future. |
|
It might be better to go the other way: update scripts to use a working directory based on the actual repo name ( |
|
The original issue is fixed via This PR can be merged. |
llxia
approved these changes
Oct 27, 2021
sophia-guo
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL ends with
STF.git, notstf.git.