Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerstatic: Add sles12 and sles15 dockerfiles #2696

Merged
merged 5 commits into from
Oct 12, 2022
Merged

Dockerstatic: Add sles12 and sles15 dockerfiles #2696

merged 5 commits into from
Oct 12, 2022

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Aug 11, 2022 •
edited
Loading

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Draft pr for sles12 and sles15 dockerfiles to be hosted on dockerhost-marist-ubuntu2204-s390x-1

ref #2689

@Haroon-Khel Haroon-Khel mentioned this pull request Aug 11, 2022
Closed
@github-actions github-actions bot added docker and removed docker labels Aug 16, 2022
@github-actions github-actions bot added docker and removed docker labels Sep 14, 2022
@Haroon-Khel Haroon-Khel marked this pull request as ready for review September 14, 2022 11:56
@Haroon-Khel
Copy link
Contributor Author

Turns out the sles12 box can pull from sles 15 repositories. @jiekang ref the possible kernel update; turns out docker containers use the host kernel anyway, so I do not think we have to worry about the sles15 repos updating the kernel here

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Sep 14, 2022 •
edited
Loading

Got a sles12 box running https://ci.adoptopenjdk.net/computer/test-docker-sles12-s390x-1/ and a sles15 box running https://ci.adoptopenjdk.net/computer/test-docker-sles15-s390x-1/, but neither have labels yet. Once merged, i'll add the labels

Sanity grinders running on both machines have shown only util tests to fail
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/5688/ (sles 12)

@Haroon-Khel
Copy link
Contributor Author

ping @sxa @steelhead31 for review

@Haroon-Khel Haroon-Khel requested a review from zdtsw September 29, 2022 11:03
steelhead31
steelhead31 approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haroon-Khel Haroon-Khel requested a review from zdtsw October 4, 2022 12:35
@Haroon-Khel
Copy link
Contributor Author

@zdtsw Is there anything stopping this pr from being merged?

@karianna karianna merged commit 57ddc9a into adoptium:master Oct 12, 2022
@sxa sxa mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelhead31 steelhead31 steelhead31 approved these changes

@zdtsw zdtsw zdtsw approved these changes

@sxa sxa Awaiting requested review from sxa

Assignees
No one assigned
Labels
ansible docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Haroon-Khel @zdtsw @steelhead31 @karianna