Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducible Comparing jobs didn't show as part of dev.functional jenkins job #3587

Closed
sophia-guo opened this issue Dec 18, 2023 · 8 comments · Fixed by #3628
Closed

Reproducible Comparing jobs didn't show as part of dev.functional jenkins job #3587

sophia-guo opened this issue Dec 18, 2023 · 8 comments · Fixed by #3628
Assignees
Labels
docker Issues related to our docker files and docker scripts macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites

Comments

@sophia-guo
Copy link
Contributor

sophia-guo commented Dec 18, 2023

Reproducible Comparing jobs were enabled as part of dev.functional, which didn't run in https://ci.adoptium.net/job/Test_openjdk21_hs_dev.functional_x86-64_linux/2/

Issues known:

@sophia-guo sophia-guo self-assigned this Dec 18, 2023
@sophia-guo
Copy link
Contributor Author

Manually set the VENDOR_TEST_REPOS and VENDOR_TEST_BRANCH and tests still didn't run https://ci.adoptium.net/job/Test_openjdk21_hs_dev.functional_x86-64_linux/4/. Must be some other issue here.

@sophia-guo
Copy link
Contributor Author

With VENDOR_TEST_DIRS tests are running VENDOR_TEST_DIRS. However dev.functional can't guarantee running on agent with 'docker installed'

@github-actions github-actions bot added docker Issues related to our docker files and docker scripts testing Issues that enhance or fix our test suites labels Dec 18, 2023
@smlambert
Copy link
Contributor

We should create a separate job for this test with the right parameters set (including ADDITIONAL_LABEL.

@github-actions github-actions bot added the macos Issues that affect or relate to the MAC OS label Dec 19, 2023
@sophia-guo
Copy link
Contributor Author

Can you clarify the separate job? Under current naming convention could the new job output be consumed by TRSS? Or we also need to update TRSS for the new job?

@smlambert
Copy link
Contributor

smlambert commented Dec 19, 2023

I think we can add it to the smoke test job with the following changes:

https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/openjdk_build_pipeline.groovy#L145 - change to dev,extended

https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/openjdk_build_pipeline.groovy#L148 to functional/buildAndPackage,functional/reproducibleCompare

Alternatively, move all smoke tests into dev

https://github.com/adoptium/temurin-build/blob/master/test/functional/buildAndPackage/playlist.xml#L21 and https://github.com/adoptium/temurin-build/blob/master/test/functional/buildAndPackage/playlist.xml#L52 to dev
https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/openjdk_build_pipeline.groovy#L145 - change to dev


Or,

Create a separate job, whatever name to call it, and start monitoring that job in TRSS (much like we have added AQA_Test_Pipeline for monitoring, downside of this approach would be that it is not hooked into the regular build pipelines.

@smlambert
Copy link
Contributor

The [make[1]: *** [settings.mk:356: dev.functional-..] Terminated](https://ci.adoptium.net/job/Test_openjdk21_hs_dev.functional_x86-64_linux/6/console) issue mentioned above was related to a dockerhost node being labelled with ci.role.test. dockerhost nodes should not get that label, as they host several static test nodes, and if tests are run directly on dockerhost, then tests on the static nodes are randomly Terminated. (see discussion in Slack thread)

@sophia-guo
Copy link
Contributor Author

As discussed those tests will move to system.dev category, which currently will only include those tests and hence resolve the docker requirement. Note this is a temp solution as going forward reproducible would not require to run in a docker container.

@smlambert
Copy link
Contributor

dev.system - yes, also to move into the system group for the reason that a reproducibility test is more of a system test than a discreet functional test. It implies that many parts of an overall system are being tested, the contents of the SBOM are correct, and all components of the product source code and the tools used to build it remain in a state of reproducibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Issues related to our docker files and docker scripts macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants