Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reproducible comparsion to aqa-tests functional dev tests #3568

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

sophia-guo
Copy link
Contributor

linux_repo_build_compare.sh is the updated one from tooling/linux_repo_build_compare.sh

@sophia-guo
Copy link
Contributor Author

If agree we might delete linux_repo_build_compare.sh in tooling

@sophia-guo sophia-guo force-pushed the AqaRepro branch 2 times, most recently from a5690ff to 295aaa5 Compare December 8, 2023 17:19
Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo
Copy link
Contributor Author

@sophia-guo sophia-guo self-assigned this Dec 11, 2023
Signed-off-by: Sophia Guo <[email protected]>
@karianna karianna requested a review from smlambert December 12, 2023 08:46
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as a first cut, thanks @sophia-guo ! We chatted about iterative refinements / next steps to improve this, is there an issue we can point to for those?

downloadAnt() {
if [ ! -r /usr/local/apache-ant-${ANT_VERSION}/bin/ant ]; then
echo Downloading ant for SBOM creation:
curl https://archive.apache.org/dist/ant/binaries/apache-ant-${ANT_VERSION}-bin.zip > /tmp/apache-ant-${ANT_VERSION}-bin.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a good idea to download ant from the apache site via our test jobs. We had cases where our IPs got blocked.

From https://archive.apache.org/:

Do note that heavy use of this service will result in immediate throttling of your download speeds to either 12 or 6 mbps for the remainder of the day, depending on severity. Continuous abuse (to the tune of more than 40 GB downloaded per week) will cause an automatic ban, so please tune your services to this fact.

and also https://infra.apache.org/infra-ban.html:

Those visiting the ASF to download products or for other reasons
If you break one of these rules, your IP will be banned from all services across the ASF.
...
More than 50 Gibibytes traffic per 12 hours.
...
More than 40GB downloaded from archive.apache.org per week.
...
If you think we banned your IP address by mistake, or if you have been banned but have an explanation why we should bend the rules for your specific case (for instance, if you have a NAT IP address that a lot of people use), contact us at [[email protected]](mailto:[email protected]) or through the "asfinfra" Slack channel. We will consider leniency and allow-listing on a case-by-case basis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it will only enable for weekly dev tests with linux. Shouldn't be a heavy use. @andrew-m-leonard I will leave for you to decide if we need to update this later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we would hit those limits, the ant zip is not large

@sophia-guo sophia-guo merged commit 375a7d1 into adoptium:master Dec 12, 2023
6 of 23 checks passed
@karianna karianna mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants