Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated reading list items #70

Open
aecreations opened this issue Feb 7, 2023 · 1 comment
Open

Duplicated reading list items #70

aecreations opened this issue Feb 7, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@aecreations
Copy link
Owner

Read Next 1.0.1

Sporadic issue with duplicated reading list items. This was observed once, and it seems that there are two conditions that trigger it: 1) it is taking longer to load; and, 2) as soon as the reading list data is loaded from local storage (fallback action if network connection times out), the sync successfully finishes and the data retrieved from Dropbox is appended to the data loaded from local storage.

Suggested fix: When sync is finished, clear the reading list before populating it with the data retrieved from Dropbox.

@aecreations aecreations added the bug Something isn't working label Feb 7, 2023
@aecreations aecreations self-assigned this Feb 7, 2023
@aecreations aecreations added this to the 1.0.2 Mauna Loa milestone Feb 7, 2023
@aecreations
Copy link
Owner Author

The reading list is already being cleared when it is built. See sidebar.js, function rebuildReadingList().

It's possible the sidebar is receiving extension messages reload-bookmarks-event (when sync finishes successfully) and sync-failed-netwk-error at the same time. There isn't a way to detect the two events happening at around the same time and cancelling one of the two.

@aecreations aecreations removed this from the 1.0.2 Mauna Loa milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant