Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] [Discussion] Adding a logic layer to flappybird #603

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Daihecyy
Copy link
Contributor

Description

Tried refactoring FlappyBird as a poc to see if adding a logic layer improves the code architecture

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the documentation, if necessary

@Daihecyy Daihecyy added enhancement New feature or request help wanted Extra attention is needed don't merge labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 59.70149% with 27 lines in your changes missing coverage. Please review.

Project coverage is 81.29%. Comparing base (64d404b) to head (a06cc5d).

Files with missing lines Patch % Lines
app/modules/flappybird/logic_flappybird.py 57.50% 17 Missing ⚠️
app/modules/flappybird/endpoints_flappybird.py 54.54% 5 Missing ⚠️
app/modules/flappybird/models_flappybird.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   81.54%   81.29%   -0.26%     
==========================================
  Files         128      129       +1     
  Lines        9929     9970      +41     
==========================================
+ Hits         8097     8105       +8     
- Misses       1832     1865      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@armanddidierjean armanddidierjean marked this pull request as draft November 16, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant