Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schools #610

Draft
wants to merge 21 commits into
base: account-type-refactoring
Choose a base branch
from
Draft

Add schools #610

wants to merge 21 commits into from

Conversation

Rotheem
Copy link
Contributor

@Rotheem Rotheem commented Oct 27, 2024

Description

Please explain the changes you made here.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the documentation, if necessary

Copy link

gitguardian bot commented Nov 18, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Rotheem Rotheem force-pushed the schools branch 2 times, most recently from 455a01b to 2d30254 Compare November 19, 2024 03:29
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 83.51648% with 30 lines in your changes missing coverage. Please review.

Project coverage is 81.13%. Comparing base (5f08b6d) to head (d09696a).

Files with missing lines Patch % Lines
app/core/schools/endpoints_schools.py 80.39% 10 Missing ⚠️
app/core/users/endpoints_users.py 68.96% 9 Missing ⚠️
app/core/schools/cruds_schools.py 82.75% 5 Missing ⚠️
app/utils/initialization.py 72.72% 3 Missing ⚠️
app/app.py 84.61% 2 Missing ⚠️
app/core/schools/schools_type.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           account-type-refactoring     #610    +/-   ##
==========================================================
  Coverage                     81.13%   81.13%            
==========================================================
  Files                           128      131     +3     
  Lines                         10003    10169   +166     
==========================================================
+ Hits                           8116     8251   +135     
- Misses                         1887     1918    +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@armanddidierjean armanddidierjean marked this pull request as draft November 21, 2024 09:18
@armanddidierjean armanddidierjean changed the base branch from main to account-type-refactoring November 21, 2024 09:19
@Rotheem Rotheem force-pushed the account-type-refactoring branch from 9227c3b to 5f08b6d Compare November 27, 2024 02:23
@Rotheem Rotheem force-pushed the account-type-refactoring branch from db2d4fb to 453bf47 Compare December 2, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant