Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sport competition module #621

Draft
wants to merge 78 commits into
base: schools
Choose a base branch
from
Draft

Sport competition module #621

wants to merge 78 commits into from

Conversation

Rotheem
Copy link
Contributor

@Rotheem Rotheem commented Nov 28, 2024

Description

Please explain the changes you made here.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the documentation, if necessary

Copy link

gitguardian bot commented Nov 28, 2024

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7298663 Triggered RSA Private Key cdf92de .env.test View secret
7298664 Triggered Generic Password 2519b20 tests/test_auth.py View secret
7298664 Triggered Generic Password 2519b20 tests/test_auth.py View secret
7298664 Triggered Generic Password cdf92de tests/test_auth.py View secret
7298664 Triggered Generic Password 2519b20 tests/test_auth.py View secret
7298664 Triggered Generic Password cdf92de tests/test_auth.py View secret
7298668 Triggered Generic High Entropy Secret cdf92de .env.test View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@armanddidierjean armanddidierjean changed the base branch from main to schools November 28, 2024 14:51
@armanddidierjean armanddidierjean marked this pull request as draft November 28, 2024 14:51
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 52.41379% with 345 lines in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (d09696a) to head (87d4528).

Files with missing lines Patch % Lines
...s/sport_competition/endpoints_sport_competition.py 26.85% 158 Missing ⚠️
...dules/sport_competition/cruds_sport_competition.py 24.51% 157 Missing ⚠️
...port_competition/dependencies_sport_competition.py 60.00% 10 Missing ⚠️
app/modules/raid/endpoints_raid.py 27.27% 8 Missing ⚠️
...dules/sport_competition/types_sport_competition.py 75.86% 7 Missing ⚠️
app/modules/raid/utils/utils_raid.py 25.00% 3 Missing ⚠️
app/modules/raid/cruds_raid.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           schools     #621      +/-   ##
===========================================
- Coverage    81.13%   79.27%   -1.87%     
===========================================
  Files          131      137       +6     
  Lines        10169    10851     +682     
===========================================
+ Hits          8251     8602     +351     
- Misses        1918     2249     +331     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant