Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove displayHost-related stuff #444

Closed
Marc-Andrieu opened this issue Oct 19, 2024 · 0 comments · Fixed by #445
Closed

Remove displayHost-related stuff #444

Marc-Andrieu opened this issue Oct 19, 2024 · 0 comments · Fixed by #445

Comments

@Marc-Andrieu
Copy link
Contributor

Marc-Andrieu commented Oct 19, 2024

Since Titan makes requests to its host only (and fonts.gstatic.com but anyway), the host-displayHost distinction introduced here is obsolete.

Discovered when trying to solve #436 by replacing "myecl.fr" with smth else (see my comment at that issue).

Marc-Andrieu added a commit that referenced this issue Dec 21, 2024
This PR fixes #444 and is made of 3 parts:
- Cleans `repository.dart`
- Apply the title of this PR everywhere
- Doesn't break Centralisation:
  - now this module uses its own simple `SectionRepository` class to get the JSON
  - and uses the new hostname, namely https://centralisation.myecl.fr
maximeroucher pushed a commit that referenced this issue Jan 11, 2025
This PR fixes #444 and is made of 3 parts:
- Cleans `repository.dart`
- Apply the title of this PR everywhere
- Doesn't break Centralisation:
  - now this module uses its own simple `SectionRepository` class to get the JSON
  - and uses the new hostname, namely https://centralisation.myecl.fr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant