Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove change_rv_size #143

Open
brandonwillard opened this issue Apr 29, 2022 · 4 comments
Open

Remove change_rv_size #143

brandonwillard opened this issue Apr 29, 2022 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed refactoring A change that improves the codebase but doesn't necessarily introduce a new feature

Comments

@brandonwillard
Copy link
Member

We need to remove change_rv_size. It's an old helper function that is no longer used and shouldn't be used in general.

Regarding the underlying functionality itself, see aesara-devs/aesara#747.
@brandonwillard brandonwillard added good first issue Good for newcomers help wanted Extra attention is needed refactoring A change that improves the codebase but doesn't necessarily introduce a new feature labels Apr 29, 2022
@ricardoV94
Copy link
Contributor

ricardoV94 commented Apr 29, 2022 •
edited
Loading

I wonder if we might need a dispatch system to resize non-pure RandomVariables like those created via OpFromGraph. Or something that would be able to resize 5.0 + at.random.normal()

@brandonwillard
Copy link
Member Author

I wonder if we might need a dispatch system to resize non-pure RandomVariables like those created via OpFromGraph. Or something that would be able to resize 5.0 + at.random.normal()

Do you mean MeasurableVariables in general?

@ricardoV94
Copy link
Contributor

Yes

@brandonwillard
Copy link
Member Author

brandonwillard commented Apr 29, 2022 •
edited
Loading

If we had a specific subclass of OpFromGraph with a known/fixed position size parameter, then I don't see why not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed refactoring A change that improves the codebase but doesn't necessarily introduce a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonwillard @ricardoV94