From 6e380c1db6f6bc9062cc964281ab149e3f547c9d Mon Sep 17 00:00:00 2001 From: Julien Robert Date: Wed, 18 Oct 2023 13:42:46 +0200 Subject: [PATCH] chore: prepare release notes v0.46.16 (#18118) --- CHANGELOG.md | 8 +++++--- RELEASE_NOTES.md | 16 +++++++++------- x/authz/keeper/keeper.go | 2 +- x/authz/keeper/keeper_test.go | 21 --------------------- 4 files changed, 15 insertions(+), 32 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6a44501ee702..d1d265b11e94 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,11 +36,13 @@ Ref: https://keepachangelog.com/en/1.0.0/ # Changelog -## [Unreleased] +## [v0.46.16](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.16) - 2023-10-16 -### Bug Fixes +EOL notice. This is the last release of the `v0.46.x` line. Per this version, the v0.46.x line reached its end-of-life. + +### Improvements -* (x/authz) [#17524](https://github.com/cosmos/cosmos-sdk/pull/17524) Fix an issue where the `cachedValue` of an authorization would not be correcty populated when there are multiple authorizations returned in `GetAuthorizations`. +* (deps) Bump cosmos/ledger-cosmos-go to v0.12.3. ## [v0.46.15](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.14) - 2023-08-21 diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 40f7869d8a7c..b895aea853fd 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,6 @@ -# Cosmos SDK v0.46.15 Release Notes +# Cosmos SDK v0.46.16 Release Notes -This patch release introduces a few bug fixes and improvements to the v0.46.x line of the Cosmos SDK. +This patch release introduces one dependency bump in the v0.46.x line of the Cosmos SDK. Ensure you have the following replaces in the `go.mod` of your application: @@ -11,11 +11,13 @@ replace github.com/tendermint/tendermint => github.com/cometbft/cometbft v0.34.2 replace github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 ``` -Please see the [CHANGELOG](https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/CHANGELOG.md) for an exhaustive list of changes. +Please see the [CHANGELOG](https://github.com/cosmos/cosmos-sdk/blob/v0.46.16/CHANGELOG.md) for an exhaustive list of changes. -**Full Commit History**: https://github.com/cosmos/cosmos-sdk/compare/v0.46.14...v0.46.15 +**Full Commit History**: https://github.com/cosmos/cosmos-sdk/compare/v0.46.15...v0.46.16 -## Deprecation Notice +## End-of-Life Notice -Get ready for v0.50.0 and start integrating with the next [Cosmos SDK](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.50.0-rc.0) release. -Once the Eden release is out, as per our [maintenance policy](https://github.com/cosmos/cosmos-sdk/blob/main/RELEASE_PROCESS.md#major-release-maintenance) we will no longer support the v0.46.x line of the Cosmos SDK, apart from critical security fixes. +`v0.46.16` is the last release of the `v0.46.x` line. Per this version, the v0.46.x line reached its end-of-life. +The SDK team maintains the [latest two major versions of the SDK](https://github.com/cosmos/cosmos-sdk/blob/main/RELEASE_PROCESS.md#major-release-maintenance). This means no features, improvements or bug fixes will be backported to the `v0.46.x` line. Per our policy, the `v0.46.x` line will receive security patches only. + +We encourage all chains to upgrade to Cosmos SDK Eden (`v0.50.0`), or the `v0.47.x` line. diff --git a/x/authz/keeper/keeper.go b/x/authz/keeper/keeper.go index e36a3b205da9..f864fa8824bf 100644 --- a/x/authz/keeper/keeper.go +++ b/x/authz/keeper/keeper.go @@ -310,9 +310,9 @@ func (k Keeper) GetAuthorizations(ctx context.Context, grantee, granter sdk.AccA iter := storetypes.KVStorePrefixIterator(store, key) defer iter.Close() + var authorization authz.Grant var authorizations []authz.Authorization for ; iter.Valid(); iter.Next() { - var authorization authz.Grant if err := k.cdc.Unmarshal(iter.Value(), &authorization); err != nil { return nil, err } diff --git a/x/authz/keeper/keeper_test.go b/x/authz/keeper/keeper_test.go index 3cce6b1fc65b..1199c127e2cd 100644 --- a/x/authz/keeper/keeper_test.go +++ b/x/authz/keeper/keeper_test.go @@ -551,27 +551,6 @@ func (s *TestSuite) TestGetAuthorization() { } } -func (s *TestSuite) TestGetAuthorizations() { - require := s.Require() - addr1 := s.addrs[1] - addr2 := s.addrs[2] - - genAuthMulti := authz.NewGenericAuthorization(sdk.MsgTypeURL(&banktypes.MsgMultiSend{})) - genAuthSend := authz.NewGenericAuthorization(sdk.MsgTypeURL(&banktypes.MsgSend{})) - - start := s.ctx.BlockHeader().Time - expired := start.Add(time.Duration(1) * time.Second) - - s.Require().NoError(s.app.AuthzKeeper.SaveGrant(s.ctx, addr1, addr2, genAuthMulti, &expired), "creating multi send grant 1->2") - s.Require().NoError(s.app.AuthzKeeper.SaveGrant(s.ctx, addr1, addr2, genAuthSend, &expired), "creating send grant 1->2") - - authzs, err := s.app.AuthzKeeper.GetAuthorizations(s.ctx, addr1, addr2) - require.NoError(err) - require.Len(authzs, 2) - require.Equal(sdk.MsgTypeURL(&banktypes.MsgMultiSend{}), authzs[0].MsgTypeURL()) - require.Equal(sdk.MsgTypeURL(&banktypes.MsgSend{}), authzs[1].MsgTypeURL()) -} - func TestTestSuite(t *testing.T) { suite.Run(t, new(TestSuite)) }