Support implicit casts from JsonDynamicValue. #16696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
approved these changes
Sep 9, 2024
src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicValue.cs
Outdated
Show resolved
Hide resolved
…micValue.cs Co-authored-by: Mike Alhayek <[email protected]>
|
@sebastienros I would like to see another approval on this PR before we release 2.0 |
sebastienros
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix to support implicit conversions from
JsonDynamicValueto other types, as it was possible before with NSJ.This should fix usages such as this one:
https://github.com/agriffard/TheBootstrapTheme/blob/9993e862945489e29170402aeaf6757c72b70ecc/src/TheBootstrapTheme/Views/Layout.cshtml#L10
Not sure if we should take this now, but if you don't mind, please check it out @agriffard .
/cc @agriffard @MikeAlhayek @sebastienros
Fixes agriffard/TheBootstrapTheme#34