From 9b6985dfa24b93043cb73ee86ef085dd503bd3aa Mon Sep 17 00:00:00 2001 From: Robbie Wagner Date: Wed, 12 Jun 2024 13:44:12 -0400 Subject: [PATCH 1/5] Add back tests for older Ember versions --- .github/workflows/ci.yml | 3 +++ tests/dummy/config/ember-try.js | 26 ++++++++++++++++++++++++++ 2 files changed, 29 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e404583..058c4bb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,6 +57,9 @@ jobs: fail-fast: false matrix: try-scenario: + - ember-lts-3.28 + - ember-lts-4.4 + - ember-lts-4.8 - ember-lts-4.12 - ember-lts-5.4 - ember-release diff --git a/tests/dummy/config/ember-try.js b/tests/dummy/config/ember-try.js index dbc77b0..abf4624 100644 --- a/tests/dummy/config/ember-try.js +++ b/tests/dummy/config/ember-try.js @@ -7,6 +7,32 @@ module.exports = async function () { return { useYarn: true, scenarios: [ + { + name: 'ember-lts-3.28', + npm: { + devDependencies: { + 'ember-data': '~3.28.0', + 'ember-resolver': '^8.0.0', + 'ember-source': '~3.28.0', + }, + }, + }, + { + name: 'ember-lts-4.4', + npm: { + devDependencies: { + 'ember-source': '~4.4.0', + }, + }, + }, + { + name: 'ember-lts-4.8', + npm: { + devDependencies: { + 'ember-source': '~4.8.0', + }, + }, + }, { name: 'ember-lts-4.12', npm: { From 3acbaf31a3882b6f81f33ceb9c6aa07f6056d576 Mon Sep 17 00:00:00 2001 From: Robbie Wagner Date: Wed, 12 Jun 2024 13:53:23 -0400 Subject: [PATCH 2/5] Adjust ember-source peerDep --- package.json | 4 ++-- yarn.lock | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index f0be633..ea2e103 100644 --- a/package.json +++ b/package.json @@ -68,7 +68,7 @@ "ember-cli-terser": "^4.0.2", "ember-load-initializers": "^2.1.2", "ember-qunit": "^8.0.2", - "ember-resolver": "^11.0.1", + "ember-resolver": "^10.0.0", "ember-source": "~5.8.0", "ember-source-channel-url": "^3.0.0", "ember-template-lint": "^5.13.0", @@ -90,7 +90,7 @@ "stylelint-prettier": "^4.1.0" }, "peerDependencies": { - "ember-source": ">= 4.0.0", + "ember-source": ">= 3.28.0", "highcharts": ">= 5.0.0" }, "engines": { diff --git a/yarn.lock b/yarn.lock index b201283..e604009 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4970,10 +4970,10 @@ ember-qunit@^8.0.2: "@embroider/macros" "^1.13.1" ember-cli-test-loader "^3.1.0" -ember-resolver@^11.0.1: - version "11.0.1" - resolved "https://registry.yarnpkg.com/ember-resolver/-/ember-resolver-11.0.1.tgz#5914e67aec7053f7148e4b0ae2d6918e830f7909" - integrity sha512-ucBk3oM+PR+AfYoSUXeQh8cDQS1sSiEKp4Pcgbew5cFMSqPxJfqd1zyZsfQKNTuyubeGmWxBOyMVSTvX2LeCyg== +ember-resolver@^10.0.0: + version "10.1.1" + resolved "https://registry.yarnpkg.com/ember-resolver/-/ember-resolver-10.1.1.tgz#1106a2386337b13a9ee509a9ad2a18b53a728ab3" + integrity sha512-y1zzn6C4YGJui+tJzcCKlsf1oSOSVAkRrvmg8OwqVIKnALKKb9ihx2qLCslHg8x0wJvJgMtDMXgrczvQrZW0Lw== dependencies: ember-cli-babel "^7.26.11" From 6eb1d4bd2c2cf444b62f2779e5df2540833aa467 Mon Sep 17 00:00:00 2001 From: Robbie Wagner Date: Wed, 12 Jun 2024 14:01:49 -0400 Subject: [PATCH 3/5] Update ember-try.js --- tests/dummy/config/ember-try.js | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/dummy/config/ember-try.js b/tests/dummy/config/ember-try.js index abf4624..230ba83 100644 --- a/tests/dummy/config/ember-try.js +++ b/tests/dummy/config/ember-try.js @@ -11,6 +11,7 @@ module.exports = async function () { name: 'ember-lts-3.28', npm: { devDependencies: { + 'ember-cli': '~3.28.0', 'ember-data': '~3.28.0', 'ember-resolver': '^8.0.0', 'ember-source': '~3.28.0', From 44fd250f715a207f1bd8e8ebdd512d8594a4ffc0 Mon Sep 17 00:00:00 2001 From: Robbie Wagner Date: Wed, 12 Jun 2024 14:10:15 -0400 Subject: [PATCH 4/5] Update ember-try.js --- tests/dummy/config/ember-try.js | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/dummy/config/ember-try.js b/tests/dummy/config/ember-try.js index 230ba83..900b0d1 100644 --- a/tests/dummy/config/ember-try.js +++ b/tests/dummy/config/ember-try.js @@ -13,6 +13,7 @@ module.exports = async function () { devDependencies: { 'ember-cli': '~3.28.0', 'ember-data': '~3.28.0', + 'ember-qunit': '^5.1.4', 'ember-resolver': '^8.0.0', 'ember-source': '~3.28.0', }, From cba89bc87ba80e94b2936bc931d4f58f0960d332 Mon Sep 17 00:00:00 2001 From: Robbie Wagner Date: Wed, 12 Jun 2024 14:14:54 -0400 Subject: [PATCH 5/5] Update ember-try.js --- tests/dummy/config/ember-try.js | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/dummy/config/ember-try.js b/tests/dummy/config/ember-try.js index 900b0d1..5d51457 100644 --- a/tests/dummy/config/ember-try.js +++ b/tests/dummy/config/ember-try.js @@ -11,6 +11,7 @@ module.exports = async function () { name: 'ember-lts-3.28', npm: { devDependencies: { + '@ember/test-helpers': '^2.4.0', 'ember-cli': '~3.28.0', 'ember-data': '~3.28.0', 'ember-qunit': '^5.1.4',