Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI C Compliance #3

Open
wojciech-graj opened this issue May 23, 2022 · 2 comments
Open

ANSI C Compliance #3

wojciech-graj opened this issue May 23, 2022 · 2 comments

Comments

@wojciech-graj
Copy link
Contributor

Hey, what are your thoughts on making the C library ANSI (C90) compliant?

The following changes would be required:

  • Replace C++-style comments (//) with C-style comments (/**/)
  • Move declarations to the start of code blocks (already occurs in most of the code)
  • Replace %lf format specifier with %f in printf in TestSGP4.c

I'd be happy and make these changes, so feel free to assign the issue to me.

@aholinch
Copy link
Owner

Thank you for taking the time to identify areas to improve ANSI compliance.

This project is using the UNLICENSE. So I will not ask for anyone to contribute code under a license that offers no protection for their work. That would not be fair to them (you), especially because the project is not really setup for collaboration.

You are welcome to make the changes yourself in your own fork. You can protect your work with whatever license you prefer.

As I review this code hopefully later this year, and potentially add support for other data formats and extend Alpha-5 support, I will look into better ANSI compliance.

@nathanodle
Copy link

I have a version that is ANSI compliant, will try to get a repo setup for you to browse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants