Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aiida-core to v2.4.0 and aiidalab to v23.3.2 #396
Bump aiida-core to v2.4.0 and aiidalab to v23.3.2 #396
Changes from all commits
350d307
1f77286
dafe020
eba3da2
08a0d7d
75045b5
2518fc0
5ff2408
9d30415
a2fd2c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is needed, since we're also installing directly from the branch in
test_install_apps_from_default_branch
. But I guess it is fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much appreciate for writing the detailed test flow, I'll test on QeApp with @superstar54 who has quite many containers with lots of calculations.
Per
--pre
options I added, it is for QeApp specifically since we didn't make the releasev23.10.0
yet but the prerelease version. The stable version is stillv23.04.6
which pinning toaiida-core~=2.3.0
will try to downgrade aiida-core and fail the test (exactly what we improved in this PR).I personally think here it is better to not use
--pre
but only test the stable version. I will keep this PR until we make the release ofv23.10.0
which the planned date is 6th November.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@unkcpz @superstar54 friendly ping, would be good to test and merge so that others can test this via the
edge
image.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, all good. The migration is run and calculations can be reloaded with showing the same result properly.