Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncSshTransport: on PR #6626 #6719

Open
khsrali opened this issue Jan 20, 2025 · 0 comments
Open

AsyncSshTransport: on PR #6626 #6719

khsrali opened this issue Jan 20, 2025 · 0 comments
Labels
type/feature request status undecided

Comments

@khsrali
Copy link
Contributor

khsrali commented Jan 20, 2025

As requested by reviewer @agoscinski , I'm documenting TODOs:

  • put & get methods could be simplified with the asyncssh.sftp.mget() & put() method or sftp.glob()
  • During verdi computer setup a variable is set as 'Hostname' and is passed as machine=computer.hostname in the to constructor of transport plugin.
    Unfortunately, name of hostname and machine are used interchangeably in the aiida-core codebase, would be nice to unify the naming.
  • Check if asyncssh is returning SFTPFileIsADirectory if SFTP.remove(dirpath), in that simplify update AsyncSshTransport accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature request status undecided
Projects
None yet
Development

No branches or pull requests

1 participant