You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As requested by reviewer @agoscinski , I'm documenting TODOs:
put & get methods could be simplified with the asyncssh.sftp.mget() & put() method or sftp.glob()
During verdi computer setup a variable is set as 'Hostname' and is passed as machine=computer.hostname in the to constructor of transport plugin.
Unfortunately, name of hostname and machine are used interchangeably in the aiida-core codebase, would be nice to unify the naming.
Check if asyncssh is returning SFTPFileIsADirectory if SFTP.remove(dirpath), in that simplify update AsyncSshTransport accordingly.
The text was updated successfully, but these errors were encountered:
As requested by reviewer @agoscinski , I'm documenting TODOs:
put
&get
methods could be simplified with theasyncssh.sftp.mget()
&put()
method orsftp.glob()
verdi computer setup
a variable is set as 'Hostname' and is passed asmachine=computer.hostname
in the to constructor of transport plugin.Unfortunately, name of hostname and machine are used interchangeably in the aiida-core codebase, would be nice to unify the naming.
asyncssh
is returningSFTPFileIsADirectory
ifSFTP.remove(dirpath)
, in that simplify updateAsyncSshTransport
accordingly.The text was updated successfully, but these errors were encountered: