Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XspectraCrystalWorkChain: WorkChain Excepts for xch_smear Core-Hole Type #1046

Open
PNOGillespie opened this issue Nov 11, 2024 · 2 comments

Comments

@PNOGillespie
Copy link
Contributor

When running calculations using the xch_smear core-hole treatment setting, the XspectraCrystalWorkChain excepts during run_all_xspectra_core. The offending lines (688-691) are:

            # remove any duplicates created from the "core_hole_treatments.yaml" defaults
            for key in new_scf_params['SYSTEM'].keys():
                if 'starting_magnetization(' in key:
                    new_scf_params['SYSTEM'].pop(key, None)

This was introduced in the last update to the WorkChain in order to make it work better with starting_magnetization settings, but causes a crash because we're poping keys from the same dictionary that we're iterating over.

@PNOGillespie
Copy link
Contributor Author

@superstar54: A fix for this is ready to go. Additionally, I found out that, due to a typo, the abs_atom_marker input for the WorkChain actually doesn't work. I will slip that change in with this one since it just involves a simple change to one line.

@superstar54
Copy link
Member

Thanks for reporting the issue and also for the fix, please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants