Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Logo in Report #149

Closed
rdmueller opened this issue Apr 28, 2017 · 7 comments
Closed

Broken Logo in Report #149

rdmueller opened this issue Apr 28, 2017 · 7 comments
Assignees

Comments

@rdmueller
Copy link
Collaborator

On my Win10 machine, I always get a broken logo rendered in the upper right corner of my reports.
I first thought that the logo is missing, but it is there and broken. Different tool complain differently when they are forced to open it.

The logo in the sources hier on github seems to be fine...

@rdmueller
Copy link
Collaborator Author

Just noticed that the arrow_up is broken in the same way.
The broken images contain (viewed with a hex editor) lots of EF BF BDsequences where non ascii values should be...

@gernotstarke
Copy link
Member

can you attach a zip of such a report, pls?

@rdmueller
Copy link
Collaborator Author

great idea :-) I should have thought of it sooner...

btw: I already tried to trace back the code which copies the ressources and there is nothing suspicious in there...

htmlchecks.zip

@rdmueller
Copy link
Collaborator Author

hm. I just searched for the plugin jar on my machine, opened it up and tried to view the images. They seem to be already broken within the plugin...
I will now try to refresh the plugin.

@rdmueller
Copy link
Collaborator Author

Still the same problem. My build fetches the plugin from

https://plugins.gradle.org/m2/gradle/plugin/org/aim42/htmlSanityCheck/0.9.6/htmlSanityCheck-0.9.6.jar

and this jar already contains the broken images...

@double16 double16 self-assigned this May 2, 2017
@double16
Copy link
Collaborator

double16 commented May 2, 2017

It's this snippet in build.gradle:

processResources {
    inputs.property "version", project.version
    filter(org.apache.tools.ant.filters.ReplaceTokens, tokens: [version: project.version])
    println "after processResources, version= ${project.version}"
}

It's processing the images as text files. I need to skip the filter for images.

@rdmueller
Copy link
Collaborator Author

works - thanx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants