aiohttp.test_utils.make_mocked_request should accept regular dict as headers [easy]

[rutsky]

Currently aiohttp.helpers.make_mocked_request doesn't support headers value type other than CIMultiDict. If you try to pass regular dict as headers and try to use such mocked request you will get error similar to:

test_aio.py:6: in handler
    assert request.headers.get('token') == 'x'
../../../stuff/aio-libs/aiohttp/aiohttp/helpers.py:442: in __get__
    val = self.wrapped(inst)
../../../stuff/aio-libs/aiohttp/aiohttp/web_reqrep.py:214: in headers
    return CIMultiDictProxy(self._message.headers)

TypeError: CIMultiDictProxy requires CIMultiDict instance, not <class 'dict'>

This can be easily fixed by adding here something like:

    if headers:
        hdrs = headers
        if not isinstance(hdrs, CIMultiDict)
           hdrs = CIMultiDict(hdrs)
        raw_hdrs = [
(k.encode('utf-8'), v.encode('utf-8')) for k, v in headers.items()]

plus add test for this case.

[jincreator]

If nobody is working on it, I'll take it.

[jincreator]

Seems someone else is already working on it...

[asvetlov]

Fixed by #1073

[rutsky]

@argaen, thanks!

[argaen]

You're welcome :).

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.