Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when use aiodns #2254

Closed
yangbo1024 opened this issue Sep 8, 2017 · 2 comments
Closed

when use aiodns #2254

yangbo1024 opened this issue Sep 8, 2017 · 2 comments
Labels

Comments

@yangbo1024
Copy link

never use aiodns,why?

in resolver.py

from .abc import AbstractResolver


__all__ = ('ThreadedResolver', 'AsyncResolver', 'DefaultResolver')

try:
    import aiodns
    # aiodns_default = hasattr(aiodns.DNSResolver, 'gethostbyname')
except ImportError:  # pragma: no cover
    aiodns = None

aiodns_default = False
# ...

DefaultResolver = AsyncResolver if aiodns_default else ThreadedResolver
@asvetlov
Copy link
Member

asvetlov commented Sep 8, 2017

Because aiodns is not dropin replacement for standard DNS API.
It works in 99% of cases but sometimes demonstrate different behavior in very rare conditions (#2237, #559)

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants