Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_client fixture broken with pytest==2.3.3 #2572

Closed
argaen opened this issue Nov 29, 2017 · 3 comments
Closed

test_client fixture broken with pytest==2.3.3 #2572

argaen opened this issue Nov 29, 2017 · 3 comments
Labels

Comments

@argaen
Copy link
Member

argaen commented Nov 29, 2017

DISCLAIMER: I don't know if this is a pytest or pytest-aiohttp problem, but I think its interesting to follow this here just in case other users ask about it. Pytest issue in pytest-dev/pytest#2975

Long story short

After upgrading to pytest==2.3.3, all tests that use the test_client fixture are skipped.

Expected behaviour

Tests using test_client fixture should run

Steps to reproduce

Super easy to reproduce:

async def test_whatever(test_client):
    pass

With

pytest==3.3.0
aiohttp==2.3.4
pytest-aiohttp==0.1.3

With pytest<=3.3.0 runs fine

@asvetlov
Copy link
Member

I think the issue is the duplicate for #2565

@argaen
Copy link
Member Author

argaen commented Nov 29, 2017

True, closing in favor of that one then

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants