Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker is broken with latest Gunicorn #269

Closed
mrdon opened this issue Feb 4, 2015 · 5 comments
Closed

Worker is broken with latest Gunicorn #269

mrdon opened this issue Feb 4, 2015 · 5 comments
Assignees
Labels

Comments

@mrdon
Copy link

mrdon commented Feb 4, 2015

With Gunicorn 19.2.0, the aiohttp.worker.GunicornWebWorker and Application needs a few patches:

  • Make Application callable as Gunicorn will error out if it isn't. It doesn't seem to matter what call does or returns.
  • The debug configuration setting doesn't exist any longer. You'll get this:
    File "/home/mrdon/dev/tmp/foo/venv/lib/python3.4/site-packages/aiohttp/worker.py", line 43, in make_handler
    debug=self.cfg.debug,
    File "/home/mrdon/dev/tmp/foo/venv/lib/python3.4/site-packages/gunicorn/config.py", line 58, in getattr
    raise AttributeError("No configuration setting for: %s" % name)

Workarounds:

  • Create a MyApplication(web.Application) class that defines a call function that is a no-op
  • Change config.py:43 to debug=False, though clearly that is just a hack.
@asvetlov
Copy link
Member

asvetlov commented Feb 4, 2015

Fixed in benoitc/gunicorn#977

@asvetlov asvetlov closed this as completed Feb 4, 2015
@fafhrd91 fafhrd91 reopened this Feb 4, 2015
@fafhrd91
Copy link
Member

fafhrd91 commented Feb 4, 2015

I'd like to work on callable

@asvetlov
Copy link
Member

asvetlov commented Feb 4, 2015

@fafhrd91 ok, that's up to you.

@fafhrd91
Copy link
Member

fixed

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants