Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2018-1000656 - JSON data encoding vulnerability #3409

Closed
messa opened this issue Nov 26, 2018 · 3 comments
Closed

CVE-2018-1000656 - JSON data encoding vulnerability #3409

messa opened this issue Nov 26, 2018 · 3 comments
Labels

Comments

@messa
Copy link

messa commented Nov 26, 2018

I've found out there was a vulnerability reported in Flask: CVE-2018-1000656

I don't know the details (could not find any exploit), but in Flask it was fixed by accepting JSON POST data only in UTF-* charset.

Perhaps aiohttp has the same issue? It looks like JSON decoding just takes whatever charset is provided in request Content-Type header.

@messa messa changed the title CVE-2018-1000656 - JSON data charset vulnerability CVE-2018-1000656 - JSON data encoding vulnerability Nov 26, 2018
@aio-libs-bot
Copy link

GitMate.io thinks the contributor most likely able to help you is @asvetlov.

Possibly related issues are #2467 (XSS Vulnerability), #815 (r.json() ), #2497 (ClientSession keep transferring data after closed), #487 (Issue with mailgun routed data?), and #1600 (aiohttp for long data processing).

@asvetlov
Copy link
Member

I don't see how Flask issue is related to aiohttp.
Please feel free to create a new issue if you'll find a real use case (more detailed vulnerability report is necessary).

@lock
Copy link

lock bot commented Nov 26, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Nov 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants