Remove make_mocked_coro()

[Dreamsorcerer]

aiohttp.test_utils.make_mocked_coro() basically does what mock.AsyncMock() does and is not relevant today.

We should remove it, but there are still a lot of references to it in the tests, so will require replacing all those references (with mock.patch, mock.create_autospec etc.).

[TheMarvelFan]

Hi,

Is anyone working on this issue?
If not, I would like to take it up.

Thanks!

[Dreamsorcerer]

Go ahead. I think there's probably a lot of uses of the function, so you may want to replace the function from a couple of files in each PR, to avoid too many change resulting in conflicts.

[TheMarvelFan]

I searched through the repo and it reports 85 references throughout the code. I think I can do this in 4 PRs, modifying roughly 20 references in each.

If you have any suggestions, please feel free to give them!

[TheMarvelFan]

Hi @Dreamsorcerer ,

I have modified a few files in this PR. Please review the changes and let me know if any corrections are required.
I will create the next PR once this one is approved.

Thanks!

[TheMarvelFan]

Hi @Dreamsorcerer ,
It looks like I am going to be busy this month, due to my approaching midterm exams. So, I would not be able to follow through with this issue.
Besides this, I also got 4 PRs merged for Hacktoberfest, so I want to leave this issue open for someone else who wants to participate.
I have closed my PR.
Hope this is understandable.

[akshayphdk]

I can take a look at this if this is still open.

[Dreamsorcerer]

Go ahead. See the linked PR and feedback for a head-start (you could start by forking that one).

[mhaoda]

Hey @akshayphdk, can I work on this issue together with you? There should be 17 files need to be updated, and If you continue the work on the linked PR (involves 13 files) I can create another PR for the rest 4 files.