Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break in finally can swallow exception #9521

Open
1 task done
iritkatriel opened this issue Oct 22, 2024 · 1 comment
Open
1 task done

break in finally can swallow exception #9521

iritkatriel opened this issue Oct 22, 2024 · 1 comment
Labels

Comments

@iritkatriel
Copy link

Describe the bug

There is a break in a finally clause in:

This can swallow any in-flight exception (like a BaseException from the try block or any exception from the except blocks).

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

To Reproduce

N/A

Expected behavior

NA

Logs/tracebacks

NA

Python Version

Source code, main branch.

aiohttp Version

NA

multidict Version

NA

propcache Version

NA

yarl Version

NA

OS

All

Related component

Server

Additional context

No response

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
@Dreamsorcerer
Copy link
Member

#7956

Feel free to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants