Chat demo not working in aiohttp 3

[robinchew]

Long story short

Want to learn websockets with example code. There's a lack of simple and runnable example code on the net demonstrating websockets in python.

Expected behaviour

Server runs and page loads

Actual behaviour

Server runs but page fails to load with following error:

~/work/aiohttp/demos/chat$ ~/venv3/bin/python aiohttpdemo_chat/main.py 
DEBUG:asyncio:Using selector: EpollSelector
======== Running on http://0.0.0.0:8080 ========
(Press CTRL+C to quit)
ERROR:aiohttp.server:Error handling request
Traceback (most recent call last):
  File "/home/robin/venv3/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 381, in start
    resp = await self._request_handler(request)
  File "/home/robin/venv3/lib/python3.6/site-packages/aiohttp/web_app.py", line 310, in _handle
    resp = await handler(request)
  File "/home/robin/venv3/lib/python3.6/site-packages/aiohttpdemo_chat-0.0.1-py3.6.egg/aiohttpdemo_chat/views.py", line 15, in index
    ok, protocol = resp.can_start(request)
AttributeError: 'WebSocketResponse' object has no attribute 'can_start'

Steps to reproduce

Just run aiohttpdemo_chat/main.py

Your environment

archlinux, aiohttp 3.0.5 server?

[robinchew]

The poll demo also does not work

[samuelcolvin]

This should probably be on https://github.com/aio-libs/aiohttp-demos.

The proper solution here is to add unit tests to that app and remember to run them (as we already do for other related projects) before major deploys.

[robinchew]

https://github.com/aio-libs/aiohttp-demos gives the same error

[gyermolenko]

This should probably be on https://github.com/aio-libs/aiohttp-demos

I also think so.
I'll try to fix it tomorrow and check with aiohttp v3

p.s. The app was created by @jettify if I'm not mistaken

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new