-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not install C sources in binary distributions #6400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how I feel about this in general but here's some actionable feedback for now.
Codecov Report
@@ Coverage Diff @@
## master #6400 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 104 104
Lines 30456 30456
Branches 3064 3064
=======================================
Hits 28429 28429
Misses 1850 1850
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Based on Andrew's comments in the issue, this will be good to go once those comments are addressed. |
This does not affect source distributions, and Cython sources (.pyx) are still installed. Fixes aio-libs#6399.
b52fa62
to
db818a0
Compare
https://github.com/aio-libs/aiohttp/runs/4458544871?check_suite_focus=true#step:10:2941
Doesn’t look like the CI failure has anything to do with the PR. |
That's probably a race condition in tests. It's not related to the CI itself but the tests could be improved, for sure. And of course, it's a separate effort/PR. I'm restarting the CI for now. |
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #6402 🤖 @patchback |
(cherry picked from commit e1ed247)
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #6403 🤖 @patchback |
(cherry picked from commit e1ed247)
…distributions (#6402) Co-authored-by: Ben Beasley <[email protected]>
…distributions (#6403) Co-authored-by: Ben Beasley <[email protected]>
This does not affect source distributions, and Cython sources (
.pyx
) arestill installed.
What do these changes do?
Prevent C sources (
_find_header.c
,_find_header.h
,_helpers.c
,_http_parser.c
,_http_writer.c
, and_websocket.c
) from being included in binary distributions such as wheels, without affecting Cython sources (_cparser.pxd
,_find_header.pxd
,_headers.pxi
,_helpers.pyx
,_http_parser.pyx
,_http_writer.pyx
, and_websocket.pyx
) or source distributions.Are there changes in behavior for the user?
Nothing changes except that the binary wheels are much smaller because they do not contain ~1.7MB of C sources.
Related issue number
Resolves #6399.
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.