Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Fix cookie handling (#6638) #6974

Conversation

galaxyfeeder
Copy link
Contributor

  • Fix cookie handling

  • Fix cookie handling

  • [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

  • Update aiohttp/cookiejar.py

Co-authored-by: Sam Bull [email protected]

Co-authored-by: Bruno Cabral [email protected]
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sam Bull [email protected]
(cherry picked from commit 916b3ee)

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

* Fix cookie handling

* Fix cookie handling

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update aiohttp/cookiejar.py

Co-authored-by: Sam Bull <[email protected]>

Co-authored-by: Bruno Cabral <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sam Bull <[email protected]>
(cherry picked from commit 916b3ee)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 26, 2022
@galaxyfeeder galaxyfeeder changed the title Fix cookie handling (#6638) [3.8] Fix cookie handling (#6638) Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #6974 (9d81563) into 3.8 (6d4ec02) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.8    #6974      +/-   ##
==========================================
+ Coverage   97.39%   97.52%   +0.13%     
==========================================
  Files         107      103       -4     
  Lines       30970    29964    -1006     
  Branches     3922     3711     -211     
==========================================
- Hits        30163    29223     -940     
+ Misses        603      556      -47     
+ Partials      204      185      -19     
Flag Coverage Δ
CI-GHA 97.39% <100.00%> (+0.13%) ⬆️
OS-Linux 96.72% <100.00%> (-0.19%) ⬇️
OS-Windows 95.23% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.78% <100.00%> (+0.13%) ⬆️
Py-3.10.6 ?
Py-3.10.7 96.68% <100.00%> (+0.12%) ⬆️
Py-3.11.0-rc.2 96.31% <100.00%> (+0.09%) ⬆️
Py-3.6.15 96.00% <100.00%> (-0.38%) ⬇️
Py-3.6.8 94.75% <100.00%> (+<0.01%) ⬆️
Py-3.7.13 ?
Py-3.7.9 94.89% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.81% <100.00%> (+<0.01%) ⬆️
Py-3.8.13 ?
Py-3.9.13 94.81% <100.00%> (-1.97%) ⬇️
Py-3.9.14 96.46% <100.00%> (+0.23%) ⬆️
Py-pypy7.3.9 96.20% <100.00%> (+0.13%) ⬆️
VM-macos 96.78% <100.00%> (+0.13%) ⬆️
VM-ubuntu 96.72% <100.00%> (-0.19%) ⬇️
VM-windows 95.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/cookiejar.py 98.83% <100.00%> (ø)
tests/test_cookiejar.py 99.07% <100.00%> (+0.03%) ⬆️
tests/test_connector.py 97.99% <0.00%> (-0.14%) ⬇️
aiohttp/client.py
aiohttp/__init__.py
aiohttp/client_ws.py
aiohttp/web_ws.py

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer
Copy link
Member

Not sure if we'll be doing another 3.8 release. But, I'll merge this in just in case.

@Dreamsorcerer Dreamsorcerer merged commit 8cf01ad into aio-libs:3.8 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants