Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showkase browser is not showing component from submodule #213

Closed
vivart opened this issue Jan 21, 2022 · 11 comments
Closed

showkase browser is not showing component from submodule #213

vivart opened this issue Jan 21, 2022 · 11 comments

Comments

@vivart
Copy link

vivart commented Jan 21, 2022

In multi module project structure, showkase browser is showing components only from the module where I have @ShowkaseRoot it's ignoring all compassable from submodules.

@vinaygaba
Copy link
Collaborator

Were you using ksp by any chance? I think there might've been a regression after we added ksp support. Can you give me more details about how this is setup.

@vivart
Copy link
Author

vivart commented Jan 23, 2022

I am not using ksp. In my project (app -> module a -> module b), I have added showkase dependencies to both the modules and I have added @ShowkaseRoot to module a. Showkase browser is showing all the components from module a but not showing anything from module b.

@Chrisjc28
Copy link

I have the same issue and raised this as part of a closed issue #205 (comment) - i might not have provided enough information the first time but to give more information this time i have a kotlin gradle script for each module - i have only one ShowkaseRootModule defined in the base module app and the other modules have got the correct dependencies

implementation("com.airbnb.android:showkase:1.0.0-beta10")
kapt("com.airbnb.android:showkase-processor:1.0.0-beta10")
@ShowkaseRoot
class AppShowCaseModule : ShowkaseRootModule
@ShowkaseColor(name = "Shade1")
val Shade1 = Color(0xFFF4F5F7)

The color values annotated with @ShowkaseColor is in my other module so app isn't pulling from this module.

@Chrisjc28
Copy link

If this helps i downgraded to 1.0.0-beta08 and it seems to be working now

@Chrisjc28
Copy link

Above 1.0.0-beta08 seems to fail to pull through the other modules components

@vivart
Copy link
Author

vivart commented Jan 24, 2022

1.0.0-beta08 seems working for me.

@vinaygaba
Copy link
Collaborator

Okay I think we have enough reports to know something broke when doing the KSP refactor. I'll be investigating this today and will keep y'all posted!

@vinaygaba
Copy link
Collaborator

Alright I have a fix for this - #216

@davidvavra
Copy link

Can we get this released please?

@vinaygaba
Copy link
Collaborator

@davidvavra
Copy link

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants