Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stacked multi preview support for KAPT #264

Open
oas004 opened this issue Sep 10, 2022 · 7 comments
Open

Add stacked multi preview support for KAPT #264

oas004 opened this issue Sep 10, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@oas004
Copy link
Contributor

oas004 commented Sep 10, 2022

As of #259 we made Showkase support stacking previews. However, because of https://youtrack.jetbrains.com/issue/KT-49682 this was not implemented for KAPT.

Making this issue to remember to add support for this when we can bump to Kotlin version 1.7.20

@vinaygaba vinaygaba added the enhancement New feature or request label Dec 20, 2022
@vinaygaba
Copy link
Collaborator

@oas004 We are on a newer version of Kotlin now. Maybe we can revisit this? Hopefully that will help simplify our code a bit and we won't need to fork between kapt and ksp as much as we do.

@oas004
Copy link
Contributor Author

oas004 commented Sep 20, 2023

Yeah that sounds like a good idea! I can check this out :)
Do you know if the plan is to continue support for KAPT with Showkase long term? Or should mostly people move to KSP? I think supporting both increases the complexity of this library a lot, so if the long term plan is to only support KSP, I'm not sure about revisiting this case. Otherwise, I will gladly look into this :)

@oas004
Copy link
Contributor Author

oas004 commented Sep 20, 2023

Furthermore, from reading though the issue referred to above, If I understand that correctly, this isn't an issue with Kotlin, but with Java annotation processing apis actually. I guess we are using those under the hood from XProcessing lib 🤔 I can try to check if XProcessing lib is supporting repeatable annotations

@vinaygaba
Copy link
Collaborator

vinaygaba commented Sep 20, 2023

Do you know if the plan is to continue support for KAPT with Showkase long term

@oas004 Good question. I thought about this a bit and I see a huge number of people still continue to use KAPT in the broader Android context, and thus even with Showkase. Moreover, my hope was that this change would simply involve getting rid of the kapt vs ksp forking in the library (assuming kapt supports the same feature set that was previously missing in Kotlin 1.5). This way, doing this would actually make the code a lot easier to reason with. In theory, you aren't building new functionality but rather getting rid of the forking.

@oas004
Copy link
Contributor Author

oas004 commented Sep 20, 2023

Yeah that makes sense to keep support for it! I can take a look at it :)
I think if XProcessing lib is supporting repeatable annotations out of the box, then I think that should work. Did you update XProcessing lib as well when moving to the newer Kotlin version? I think if I remember correctly, we have tests that are checking the repeatable annotation feature for KAPT, so I think those would fail if they have support for it? 🤔

@vinaygaba
Copy link
Collaborator

@oas004 Interesting. Yes the version of xprocessing was upgraded, although it's not the latest version. Was done in this PR - 360259e

@oas004
Copy link
Contributor Author

oas004 commented Sep 20, 2023

Aha okay, I see the version was updated to 2.6.0-alpha01. I think the newest one is 2.6.0-beta01. I can try that, but I'm doubtful that it will change much as it is only an alpha -> beta change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants