-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stacked multi preview support for KAPT #264
Comments
@oas004 We are on a newer version of Kotlin now. Maybe we can revisit this? Hopefully that will help simplify our code a bit and we won't need to fork between kapt and ksp as much as we do. |
Yeah that sounds like a good idea! I can check this out :) |
Furthermore, from reading though the issue referred to above, If I understand that correctly, this isn't an issue with Kotlin, but with Java annotation processing apis actually. I guess we are using those under the hood from XProcessing lib 🤔 I can try to check if XProcessing lib is supporting repeatable annotations |
@oas004 Good question. I thought about this a bit and I see a huge number of people still continue to use KAPT in the broader Android context, and thus even with Showkase. Moreover, my hope was that this change would simply involve getting rid of the kapt vs ksp forking in the library (assuming kapt supports the same feature set that was previously missing in Kotlin 1.5). This way, doing this would actually make the code a lot easier to reason with. In theory, you aren't building new functionality but rather getting rid of the forking. |
Yeah that makes sense to keep support for it! I can take a look at it :) |
Aha okay, I see the version was updated to 2.6.0-alpha01. I think the newest one is 2.6.0-beta01. I can try that, but I'm doubtful that it will change much as it is only an alpha -> beta change. |
As of #259 we made Showkase support stacking previews. However, because of https://youtrack.jetbrains.com/issue/KT-49682 this was not implemented for KAPT.
Making this issue to remember to add support for this when we can bump to Kotlin version 1.7.20
The text was updated successfully, but these errors were encountered: