Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom MutliPreview annotations don't respect skipPrivatePreviews #312

Closed
undermark5 opened this issue Apr 4, 2023 · 4 comments · Fixed by #313
Closed

Custom MutliPreview annotations don't respect skipPrivatePreviews #312

undermark5 opened this issue Apr 4, 2023 · 4 comments · Fixed by #313

Comments

@undermark5
Copy link

Issue #233 and associated resolution PR #303 fail to properly handle MultiPreview annotations.

While trying to configure this in my project, I have a few custom multi preview annotations that are added to some private functions. The KSP step complains stating that the methods can't be private and that if I want it to skip them, I must configure the ksp arguments, which I have done, so the message is actually in error and the multipreview on private methods should be skipped.

@oas004
Copy link
Contributor

oas004 commented Apr 4, 2023

Thanks for the report! I tested it out now, and I can reproduce it. Will try to fix it as fast as possible.

@jd565
Copy link

jd565 commented May 5, 2023

@oas004 Any idea when this will get into a release? We are hit this problem when updating to beta 18 and it causes an error in ksp and the build fails.

@oas004
Copy link
Contributor

oas004 commented May 5, 2023

@jd565 I think that will be up to @vinaygaba and Airbnb when they will release a new version :)

@SumeraMartin
Copy link

@vinaygaba Hi, since this is merged, are you planning to release new version? I would be very happy since this is something that is blocking me currently in my project 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants