In subquery use alias to do 'order by' (#795)

* in subqry add orderby metric to select * add comment
apache · Jul 22, 2016 · 19f5371 · 19f5371
1 parent 9cdd289
commit 19f5371
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/caravel/models.py b/caravel/models.py
@@ -728,6 +728,9 @@ def query(  # sqla
         qry = qry.limit(row_limit)
 
         if timeseries_limit and groupby:
+            # some sql dialects require for order by expressions 
+            # to also be in the select clause
+            inner_select_exprs += [main_metric_expr]
             subq = select(inner_select_exprs)
             subq = subq.select_from(tbl)
             subq = subq.where(and_(*(where_clause_and + inner_time_filter)))