Make sure cache.set never fails hard (#611)

apache · Jun 13, 2016 · 267c019 · 267c019
1 parent 9ed8c32
commit 267c019
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/caravel/viz.py b/caravel/viz.py
@@ -261,7 +261,12 @@ def get_json(self):
             payload['cached_dttm'] = datetime.now().isoformat().split('.')[0]
             logging.info("Caching for the next {} seconds".format(
                 cache_timeout))
-            cache.set(cache_key, payload, timeout=cache_timeout)
+            try:
+                cache.set(cache_key, payload, timeout=cache_timeout)
+            except Exception as e:
+                # cache.set call can fail if the backend is down or if
+                # the key is too large or whatever other reasons
+                logging.warning("Could not cache key {}".format(cache_key))
         payload['is_cached'] = is_cached
         return self.json_dumps(payload)